Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required option when importing a disk image #877

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

valeriopoggi
Copy link
Contributor

SUMMARY

The Azure API requires the Azure Resource Manager identifier of the storage account containing the blob to import as a disk.

This PR adds the storage_account_id option to the azure_rm_manageddisk module.

Fixes: #394

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_manageddisk

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 13, 2022
@Fred-sun Fred-sun assigned xuzhang3 and unassigned xuzhang3 Jun 13, 2022
@Fred-sun Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels Jun 13, 2022
valeriopoggi and others added 2 commits June 14, 2022 23:23
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 20, 2022
@xuzhang3
Copy link
Collaborator

@valeriopoggi LGTM

@xuzhang3 xuzhang3 merged commit a135009 into ansible-collections:dev Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_manageddisk: Required parameter 'storageAccountId' is missing (null).
3 participants