-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection details to azure_rm_privateendpoint_info #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
Aug 30, 2022
Fred-sun
added
medium_priority
Medium priority
work in
In trying to solve, or in working with contributors
labels
Aug 30, 2022
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
reviewed
Aug 30, 2022
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
reviewed
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete lines 160 to 166
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
reviewed
Aug 30, 2022
Fred-sun
added
ready_for_review
The PR has been modified and can be reviewed and merged
and removed
work in
In trying to solve, or in working with contributors
labels
Aug 31, 2022
xuzhang3
approved these changes
Sep 8, 2022
@dhageman LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
medium_priority
Medium priority
ready_for_review
The PR has been modified and can be reviewed and merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
This code modifies azure_rm_privateendpoint_info to return the connection details associated with a private endpoint. This is necessary for private endpoints that don't connect to a private link service as the newly added azure_rm_privateendpointconnection_info only supports those type of links. The primary motivation for this feature is to allow identification of private endpoints that are pointing to resources which no longer exist.
ADDITIONAL INFORMATION
This pull request introduces a change in the output of the command. It will return a complex type instead of an array of connection id strings.
Old result:
New result: