Allow to run x509_certificate selfsigned provider without providing a CSR #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2020
Closed
|
ready_for_review |
|
Hm, I'm still not sure if the resulting certificates are very useful, but I've already seen examples where certificates were just used to encode the public key for a key pair. Anyways, the code looks good to me. /shipit |
|
I agree with that :) |
|
@MarkusTeufelberger thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The module will act as if a minimal CSR only containing the public key has been provided.
Fixes #32.
ISSUE TYPE
COMPONENT NAME
x509_certificate