fix custom file attributes for public keys #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributoin! Can you please add a changelog fragment? |
Use of the confusingly-named _permissions_changed() on both sides of an `or` was resulting in the second invocation not being reached if the first invocation returned True, which it does any time it applied custom attributes to the private key. As a result, custom file attributes were only ever being applied to the private key (except in one specific case) This is fixed by explicitly updating attributes of both files before checking if changes have been made. Signed-off-by: Charlie Wheeler-Robinson <cwheeler@redhat.com>
crwr45
force-pushed
the
pubkey_permissions
branch
from
7b60859
to
e114e75
Compare
Ajpantuso
approved these changes
Jul 20, 2021
felixfontein
approved these changes
Jul 20, 2021
|
@crwr45 thanks for fixing this! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the confusingly-named _permissions_changed() on both
sides of an
orwas resulting in the second invocation notbeing reached if the first invocation returned True.
This is fixed by explicitly running both invocations
before evaluating the return values.
Signed-off-by: Charlie Wheeler-Robinson cwheeler@redhat.com
ISSUE TYPE