Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509_crl: support DER format for CRLs #29

Merged

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Apr 11, 2020

SUMMARY

Contains #27. Will be rebased and un-WIP'ed once that is merged.

Adds support for DER-encoded CRLs. (They seem to be more common than PEM-encoded CRLs, what is what the module currently only supports.)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

x509_crl
x509_crl_info

@felixfontein felixfontein changed the title [WIP] x509_crl: support DER format for CRLs x509_crl: support DER format for CRLs May 12, 2020
@felixfontein
Copy link
Contributor Author

ready_for_review

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

becides the lack of blank lines in the part of tests, LGTM

@felixfontein felixfontein merged commit de3c99e into ansible-collections:master May 15, 2020
@felixfontein felixfontein deleted the x509_crl-format branch May 15, 2020 07:57
@felixfontein
Copy link
Contributor Author

@Andersson007 thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants