Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other deprecations #290

Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Remove deprecations which are unrelated to the assertonly deprecations.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various redirects, features, ...

@felixfontein
Copy link
Contributor Author

ready_for_review

The remaining errors will go away once the collection version in galaxy.yml is pushed to 2.0.0. Doing that in this PR will trigger other failures, so let's keep this until the other PRs are merged, re-run CI then (some conflicts will probably need to be resolved), and then merge.

@felixfontein
Copy link
Contributor Author

I've rebased and bumped the version in galaxy.yml to 2.0.0.

ready_for_review

@felixfontein
Copy link
Contributor Author

@Ajpantuso @MarkusTeufelberger would be glad if (at least) one of you could take a look at this one :)

Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't have much background for these deprecations, but I also don't see any issues.

@felixfontein felixfontein merged commit a581f1e into ansible-collections:main Oct 16, 2021
@felixfontein felixfontein deleted the remove-deprecations branch October 16, 2021 19:00
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants