Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certificate_complete_chain: avoid infinite loops, and double roots when root certificate was already part of chain #360

Merged
merged 2 commits into from
Jan 4, 2022
Merged

certificate_complete_chain: avoid infinite loops, and double roots when root certificate was already part of chain #360

merged 2 commits into from
Jan 4, 2022

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Avoid infinite loops, and double roots when root certificate was already part of chain.

Fixes #355.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

certificate_complete_chain

@felixfontein felixfontein mentioned this pull request Jan 1, 2022
Closed
briantist
briantist approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small style comment in the integration tests but one I'd consider completely optional, looks good to me

tests/integration/targets/certificate_complete_chain/tasks/main.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein merged commit 6ee238d into ansible-collections:main Jan 4, 2022
@patchback
Copy link

patchback bot commented Jan 4, 2022 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/6ee238d9617b6d6f30333bda64ec4247a46fbd97/pr-360

Backported as #366

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the fix-endless-loop branch January 4, 2022 06:00
patchback bot pushed a commit that referenced this pull request Jan 4, 2022
@felixfontein @patchback
certificate_complete_chain: avoid infinite loops, and double roots wh…
d0419e1 
…en root certificate was already part of chain (#360)

* Avoid infinite loops, and double roots when root certificate was already part of chain.

* Refactor tests for readability.

(cherry picked from commit 6ee238d)
@patchback patchback bot mentioned this pull request Jan 4, 2022
Merged
@felixfontein
Copy link
Contributor Author

@briantist thanks for reviewing this!

felixfontein added a commit that referenced this pull request Jan 4, 2022
@patchback @felixfontein
certificate_complete_chain: avoid infinite loops, and double roots wh…
20b0d7a 
…en root certificate was already part of chain (#360) (#366)

* Avoid infinite loops, and double roots when root certificate was already part of chain.

* Refactor tests for readability.

(cherry picked from commit 6ee238d)

Co-authored-by: Felix Fontein <felix@fontein.de>
@renovate renovate bot mentioned this pull request Jan 10, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

endless loop when root certificate is found in intermediate certificates set
2 participants
@felixfontein @briantist