Make request timeout configurable for all acme modules

[JonasVerhofste]

SUMMARY

Makes request timeouts configurable for all acme_-modules that use the shared acme argspec. Fixes #447.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/module_utils/acme/acme.py; affected modules:
acme_account.py
acme_account_info.py
acme_inspect.py
acme_certificate.py
acme_certificate_revoke.py

ADDITIONAL INFORMATION

Added timeout as an alias because it seemed logical, not sure if that's allowed (i.e. if that is usually only used for backwards compatible changes).

[JonasVerhofste]

Oh right, let me add some tests..

[JonasVerhofste]

@felixfontein Where would you suggest adding this to the tests (if needed at all)?

[felixfontein]

Thanks for your contribution! Could you please add a changelog fragment?

About the alias: I would not add timeout as an alias to make it possible to use that name for something else in the future. For example, acme_certificate could have a timeout for the second stage where it eventually gives up waiting for the finalization to take place. Once such a functionality is there, I would expect timeout to be in control of that one. (It will probably be best to use a different name for that one as well, and not use timeout at all, to make it less confusing.)

[felixfontein]

@felixfontein Where would you suggest adding this to the tests (if needed at all)?

Timeouts are hard to test with integration tests (without having an endpoint supporting that usage), so unit tests would be best. But since we right now have to unit tests for anything HTTP related, I think it's ok to not add tests here.

[JonasVerhofste]

@felixfontein removed the timeout alias and added the changelog fragment!

[felixfontein]

@JonasVerhofste thanks for implementing this!