Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL9 - Retrieve python3-pyOpenSSL from epel #575

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

austlane
Copy link
Contributor

SUMMARY

With the release of CentOS 9 / RHEL 9. python3-pyOpenSSL has been moved from the AppStream repo to epel.

Currently, attempting to include community.crypto in an el9-based Execution Environment results in failure. This PR corrects the issue using the epel ansible-builder profile documented here ansible/ansible-builder#156

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bindep dependency resolution

@felixfontein
Copy link
Contributor

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

I'll take a closer look at the PR later.

meta/ee-bindep.txt Outdated Show resolved Hide resolved
austlane added a commit to austlane/ansible-community.crypto that referenced this pull request Feb 15, 2023
@austlane
Copy link
Contributor Author

Incorporated suggested changes from @felixfontein and added a changelog fragment. Should be good to go 👍

@felixfontein
Copy link
Contributor

Did you test the changes on RHEL 9 and/or CentOS Stream 9? The EE base images used in CI are all CentOS Stream 8 based, so they only test part of this.

@felixfontein
Copy link
Contributor

Oh, and could you please rebase and remove the @ from the commit message? Having @felixfontein in there will cause me to get notifications every single time someone pushes this commit to their repo (like when updating their fork of this repo to the latest state once this PR is merged), and I'd prefer not to get that stream of notifications :D

@felixfontein
Copy link
Contributor

@austlane ping - if you want this to appear in the next release please answer soon. I want to do a release today or tomorrow.

@austlane
Copy link
Contributor Author

austlane commented Feb 22, 2023

@felixfontein rebased with the @ removed!

I have tested this against Centos 9 Stream, which is used in awx-ee.
I have not tested against RHEL9 (as used in the Redhat Ansible Automation Platform), as I do not have a subscription 😢

@felixfontein
Copy link
Contributor

I have not tested against RHEL9 (as used in the Redhat Ansible Automation Platform), as I do not have a subscription cry

Same here ;) I would expect it to behave the same...

@felixfontein felixfontein merged commit ced0e30 into ansible-collections:main Feb 22, 2023
@felixfontein
Copy link
Contributor

@austlane thanks a lot for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants