Improve PEM identification #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarkusTeufelberger @Ajpantuso if you have time to review this, a review would be appreciated :) |
|
Seems weird that The "extract_first_pem()" code seems to be in https://docs.rs/pem/latest/pem/ and maybe also a little bit exposed in https://github.com/pyca/cryptography/blob/35219339d937b35435813d0995b5573a1d665cf2/src/rust/src/x509/common.rs#L16, but I'm not sure if that's much better than just rolling our own for now. LGTM |
|
@MarkusTeufelberger it would be nice if it would expose that... Unfortunately even if they changed that now, it would take years until we could fully rely on it and stop having our own code for it :) |
|
@Ajpantuso @MarkusTeufelberger thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #627.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/crypto/pem.py