Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs_certificate: allow to request renewal without csr #740

Merged
merged 3 commits into from
May 9, 2024
Merged

ecs_certificate: allow to request renewal without csr #740

merged 3 commits into from
May 9, 2024

Conversation

francescolovecchio
Copy link
Contributor

SUMMARY

See specification and module documentation

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_certificate

ADDITIONAL INFORMATION

Renew certificate requests without csr failed with:

The csr field is required when request_type=renew

@felixfontein
Copy link
Contributor

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@felixfontein
Copy link
Contributor

CC @ctrufan

@francescolovecchio
Copy link
Contributor Author

@felixfontein changelog fragment added! Thanks

@felixfontein
Copy link
Contributor

@sapnajainEntrust do you know whom to contact from Entrust's side to review this? @ctrufan doesn't seem to be active on GitHub anymore.

@ctrufan
Copy link
Collaborator

ctrufan commented May 9, 2024 •
edited
Loading

Sorry about the delay. Looks good, thanks for the fixes!

@ctrufan ctrufan assigned ctrufan and unassigned ctrufan May 9, 2024
@ctrufan ctrufan self-requested a review May 9, 2024 15:49
ctrufan
ctrufan approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ctrufan ctrufan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are consistent with (newer versions of) Entrust API specification.

@felixfontein felixfontein merged commit 29ac3cb into ansible-collections:main May 9, 2024
142 checks passed
@patchback Patchback
Copy link

patchback bot commented May 9, 2024 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/29ac3cbe8174be1e8a3177f588e29fa8eac182e0/pr-740

Backported as #752

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 9, 2024
@francescolovecchio @patchback
ecs_certificate: allow to request renewal without csr (#740)
9b3cf3c 
* renew request CSR validation

* Create 740-ecs_certificate-renewal-without-csr

* Rename 740-ecs_certificate-renewal-without-csr to 740-ecs_certificate-renewal-without-csr.yml

---------

Co-authored-by: flovecchio <flovecchio@sorint.com>
(cherry picked from commit 29ac3cb)
@patchback patchback bot mentioned this pull request May 9, 2024
Merged
@felixfontein
Copy link
Contributor

@francescolovecchio thanks for this fix!
@ctrufan thanks for reviewing! good to see you again :)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.crypto/branch/main

felixfontein pushed a commit that referenced this pull request May 9, 2024
@patchback @francescolovecchio
ecs_certificate: allow to request renewal without csr (#740) (#752)
29ed12e 
* renew request CSR validation

* Create 740-ecs_certificate-renewal-without-csr

* Rename 740-ecs_certificate-renewal-without-csr to 740-ecs_certificate-renewal-without-csr.yml

---------

Co-authored-by: flovecchio <flovecchio@sorint.com>
(cherry picked from commit 29ac3cb)

Co-authored-by: francescolovecchio <francescolovecchio97@gmail.com>
austinlucaslake pushed a commit to austinlucaslake/community.crypto that referenced this pull request May 25, 2024
@francescolovecchio @austinlucaslake
ecs_certificate: allow to request renewal without csr (ansible-collec…
89da989 
…tions#740)

* renew request CSR validation

* Create 740-ecs_certificate-renewal-without-csr

* Rename 740-ecs_certificate-renewal-without-csr to 740-ecs_certificate-renewal-without-csr.yml

---------

Co-authored-by: flovecchio <flovecchio@sorint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@ctrufan ctrufan ctrufan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francescolovecchio @felixfontein @ctrufan