Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #75

Merged
merged 15 commits into from
Jul 1, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Do some generic cleanup; set deprecation versions to 2.0.0.

Fixes #73.

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

collection

@MarkusTeufelberger
Copy link
Contributor

The ignores in the sanity tests could also be deactivated I think?

@felixfontein
Copy link
Contributor Author

@MarkusTeufelberger did that in ec839dc (forgot to commit that before the first push...)

@felixfontein felixfontein mentioned this pull request Jun 21, 2020
@MarkusTeufelberger
Copy link
Contributor

Maybe a small "Roadmap/future deprecations" section in the README would be nice to have? On the other hand it is already quite clear that pyopenssl will be gone with 2.0.0 - still it could calm down some people by ensuring them that we aren't going to end support as long as there are upstream supported mainstream distributions (Debian, Ubuntu, CentOS, Fedora, Alpine, Arch, Suse, ...?) out there that wouldn't be able to run these modules with native packages.

@felixfontein
Copy link
Contributor Author

I've updated the README a bit, and fleshed out the roadmap section.

@felixfontein
Copy link
Contributor Author

Finally passes all tests :)

@felixfontein
Copy link
Contributor Author

@MarkusTeufelberger mind if I merge this? Or do you want to check the README.md changes first (or some other changes)?

3. Add the directory containing `ansible_collections` to your [ANSIBLE_COLLECTIONS_PATHS](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths).
3. Add the directory containing `ansible_collections` to your [ANSIBLE_COLLECTIONS_PATH](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths).

See [Ansible's dev guide](https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#contributing-to-collections) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Maybe we should not link to the "devel" version in the future here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. But the non-devel link does not exist yet (at least that anchor).

README.md Outdated

## Release notes

<!--Add a link to a changelog.md file or an external docsite to cover this information. -->
See the [changelog](https://github.com/ansible-collections/collection_template/blob/master/CHANGELOG.rst).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will exist once the first release is created :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In collection_template?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, great catch! I really wonder where I copied that from...

@MarkusTeufelberger
Copy link
Contributor

shipit :-)

@felixfontein felixfontein merged commit 390cb1c into ansible-collections:master Jul 1, 2020
@felixfontein felixfontein deleted the prepare-release branch July 1, 2020 11:49
@felixfontein
Copy link
Contributor Author

@MarkusTeufelberger thanks a lot for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require Ansible 2.9.10+ and add deprecation notices to modules
2 participants