Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certificate_complete_chain: add ability to identify ed25519 complete chains #777

Merged
merged 6 commits into from
Jul 11, 2024
Merged

certificate_complete_chain: add ability to identify ed25519 complete chains #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c03fff0
Add ability to identify ed25519 complete chains.
gderber Jul 8, 2024
1aa150c
Add ability to identify ed448 complete chains.
gderber Jul 10, 2024
6ac8181
Formatting updates
gderber Jul 10, 2024
001061c
Remove unnecessary imports.
gderber Jul 11, 2024
1b1729c
Cleanup whitespace
gderber Jul 11, 2024
eb2e4ff
Fix algorithm names capitalization.
gderber Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/777-add_ability_to_identify_ed25519_complete_chains.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- certificate_complete_chain - add ability to identify Ed25519 and Ed448 complete chains (https://github.com/ansible-collections/community.crypto/pull/777).
11 changes: 11 additions & 0 deletions plugins/modules/certificate_complete_chain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
split_pem_list,
)

from ansible_collections.community.crypto.plugins.module_utils.crypto.basic import (
CRYPTOGRAPHY_HAS_ED448_SIGN,
CRYPTOGRAPHY_HAS_ED25519_SIGN,
)

felixfontein marked this conversation as resolved.
Show resolved Hide resolved
CRYPTOGRAPHY_IMP_ERR = None
try:
import cryptography
Expand Down Expand Up @@ -196,6 +201,12 @@ def is_parent(module, cert, potential_parent):
cert.cert.tbs_certificate_bytes,
cryptography.hazmat.primitives.asymmetric.ec.ECDSA(cert.cert.signature_hash_algorithm),
)
elif CRYPTOGRAPHY_HAS_ED25519_SIGN and isinstance(
public_key, cryptography.hazmat.primitives.asymmetric.ed25519.Ed25519PublicKey):
public_key.verify(cert.cert.signature, cert.cert.tbs_certificate_bytes)
elif CRYPTOGRAPHY_HAS_ED448_SIGN and isinstance(
public_key, cryptography.hazmat.primitives.asymmetric.ed448.Ed448PublicKey):
public_key.verify(cert.cert.signature, cert.cert.tbs_certificate_bytes)
else:
# Unknown public key type
module.warn('Unknown public key type "{0}"'.format(public_key))
Expand Down