openssl_csr: add support for name constraints extension #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready_for_review |
|
Ok, I had to add another commit. While adding this feature, I noticed that IP address ranges weren't supported at all so far. They cannot be used for SANs, but they can (and must - IP addresses won't work) be used for name constraints. I originally wanted to create a new PR for this, but noticed that I can only test it once this is merged - so I added it here :) |
felixfontein
force-pushed
the
openssl_csr-name-constraints
branch
from
964ebc0
to
9dec640
Compare
|
(rebased to remove conflict) |
Closed
|
Looks good to me. Shipit! :-) |
|
@MarkusTeufelberger thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #46.
ISSUE TYPE
COMPONENT NAME
openssl_csr
openssl_csr_info