-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker_swarm_service option publish.published_port optional #101
Make docker_swarm_service option publish.published_port optional #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This needs a changelog fragment.
- The remaining sanity error (
no-log-required
) will be fixed by docker_swarm_service: flag secrets option as not secret #102, just ignore it.
CC maintainers @dariko @jwitko @hannseman @WojciechowskiPiotr
Happy to merge it when the changelog is updated. |
f2d79a5
to
c89c72b
Compare
Added, and squashed into one commit. Thanks! |
…ed to optional. If not specified random high port is assigned by docker.
c89c72b
to
b8ea529
Compare
@felixfontein can you take a look at why tests are still failing? #102 has been merged. |
changelogs/fragments/101-make-service-published-port-optional.yaml
Outdated
Show resolved
Hide resolved
@WojciechowskiPiotr they failed because collection installation from galaxy failed (after three trials). That seems to happen a lot more since yesterday or so (ansible/galaxy#2429). Once the suggestion is merged tests will run another time anyway, and if some fail again I'll kick them until they pass :) |
…yaml Co-authored-by: Felix Fontein <felix@fontein.de>
Everything looks good to me (but then I'm not that familiar with Docker swarm), so feel free to merge. I'll create a new release once this is merged to get the security fix out. |
@sgpinkus thanks for fixing this! |
SUMMARY
Change docker_swarm_service option publish.published_ported to optional. If not specified random high port is assigned by docker. Fixes #99.
ISSUE TYPE
COMPONENT NAME
docker_swarm_service
ADDITIONAL INFORMATION
This now works A free high port above 30000 will be assigned by docker: