Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow passing the --allow-root flag to kibana_plugin module #2014

Merged
merged 3 commits into from
Mar 15, 2021
Merged

allow passing the --allow-root flag to kibana_plugin module #2014

merged 3 commits into from
Mar 15, 2021

Conversation

dacodas
Copy link
Contributor

@dacodas dacodas commented Mar 13, 2021

SUMMARY

Allow specifying an allow_root option to pass the --allow-root flag to the kibana and kibana-plugin commands.

The Kibana RPM from Elasticsearch by default installs everything as root, so this module fails when trying to

  1. Run kibana --version since it cannot read /etc/kibana/kibana.yml
  2. Modify /usr/share/kibana/plugins since it is only writeable by root
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

kibana-plugin

ADDITIONAL INFORMATION

Please let me know if I can provide any more information or need to make any further changes.

Thank you

@ansibullbot
Copy link
Collaborator

cc @barryib
click here for bot help

@ansibullbot ansibullbot added affects_2.10 community_review database feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 13, 2021
felixfontein
felixfontein reviewed Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Please add a changelog fragment and make the changes mentioned below. Thanks!

About the failed CI runs: that are problems with Ansible Galaxy and are unrelated to this PR. Simply ignore them :) I haven't restarted them since you need to add another commit anyway, so they will run again anyway...

plugins/modules/database/misc/kibana_plugin.py Outdated Show resolved Hide resolved
plugins/modules/database/misc/kibana_plugin.py Outdated Show resolved Hide resolved
aminvakil
aminvakil reviewed Mar 14, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Taken from https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to:

Each changelog entry must contain a link to its issue between parentheses at the end. If there is no corresponding issue, the entry must contain a link to the PR itself.

changelogs/fragments/2014-allow-root-for-kibana-plugin.yaml Outdated Show resolved Hide resolved
felixfontein
felixfontein reviewed Mar 14, 2021
View reviewed changes
plugins/modules/database/misc/kibana_plugin.py
@@ -169,6 +175,9 @@ def install_plugin(module, plugin_bin, plugin_name, url, timeout, kibana_version
if timeout:
cmd_args.append("--timeout %s" % timeout)

if allow_root:
cmd_args.append('--allow-root')

cmd = " ".join(cmd_args)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone wants to further improve this module after this PR, getting rid of these lines (and making sure that every parameter is in its own string in cmd_args) would be a nice follow-up for this PR!

@dacodas @felixfontein
add changelog fragment for kibana_plugin --allow-root
b9e40b6 
Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 15, 2021
aminvakil
aminvakil approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 15, 2021
@felixfontein felixfontein merged commit 3162ed6 into ansible-collections:main Mar 15, 2021
patchback bot pushed a commit that referenced this pull request Mar 15, 2021
@dacodas
allow passing the --allow-root flag to kibana_plugin module (#2014)
8c0d2c4 
* kibana_plugin module parameter force is a boolean

* allow passing the --allow-root flag to kibana_plugin module

* add changelog fragment for kibana_plugin --allow-root

Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 3162ed6)
@patchback patchback bot mentioned this pull request Mar 15, 2021
Merged
@felixfontein
Copy link
Collaborator

@dacodas thanks for contributing this!
@aminvakil thanks for reviewing!

@aminvakil
Copy link
Contributor

@dacodas Thanks for adding this!
@felixfontein Thanks for fixing my review!

felixfontein pushed a commit that referenced this pull request Mar 15, 2021
@patchback @dacodas
allow passing the --allow-root flag to kibana_plugin module (#2014) (#…
a83556a 
…2022)

* kibana_plugin module parameter force is a boolean

* allow passing the --allow-root flag to kibana_plugin module

* add changelog fragment for kibana_plugin --allow-root

Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 3162ed6)

Co-authored-by: dacodas <dacoda.strack@gmail.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 2, 2021
ansible: updated to 3.2.0
d789ad6 
v3.2.0

community.crypto
- acme module_utils - the ``acme`` module_utils has been split up into several Python modules (ansible-collections/community.crypto#184).
- acme_* modules - codebase refactor which should not be visible to end-users (ansible-collections/community.crypto#184).
- acme_* modules - support account key passphrases for ``cryptography`` backend (ansible-collections/community.crypto#197, ansible-collections/community.crypto#207).
- acme_certificate_revoke - support revoking by private keys that are passphrase protected for ``cryptography`` backend (ansible-collections/community.crypto#207).
- acme_challenge_cert_helper - add ``private_key_passphrase`` parameter (ansible-collections/community.crypto#207).

community.docker
- docker_swarm_service - change ``publish.published_port`` option from mandatory to optional. Docker will assign random high port if not specified (ansible-collections/community.docker#99).

community.general
- archive - refactored some reused code out into a couple of functions (ansible-collections/community.general#2061).
- csv module utils - new module_utils for shared functions between ``from_csv`` filter and ``read_csv`` module (ansible-collections/community.general#2037).
- ipa_sudorule - add support for setting sudo runasuser (ansible-collections/community.general#2031).
- jenkins_job - add a ``validate_certs`` parameter that allows disabling TLS/SSL certificate validation (ansible-collections/community.general#255).
- kibana_plugin - add parameter for passing ``--allow-root`` flag to kibana and kibana-plugin commands (ansible-collections/community.general#2014).
- proxmox - added ``purge`` module parameter for use when deleting lxc's with HA options (ansible-collections/community.general#2013).
- proxmox inventory plugin - added ``tags_parsed`` fact containing tags parsed as a list (ansible-collections/community.general#1949).
- proxmox_kvm - added new module parameter ``tags`` for use with PVE 6+ (ansible-collections/community.general#2000).
- rax - elements of list parameters are now validated (ansible-collections/community.general#2006).
- rax_cdb_user - elements of list parameters are now validated (ansible-collections/community.general#2006).
- rax_scaling_group - elements of list parameters are now validated (ansible-collections/community.general#2006).
- read_csv - refactored read_csv module to use shared csv functions from csv module_utils (ansible-collections/community.general#2037).
- redfish_* modules, redfish_utils module utils - add support for Redfish session create, delete, and authenticate (ansible-collections/community.general#1975).
- snmp_facts - added parameters ``timeout`` and ``retries`` to module (ansible-collections/community.general#980).
- vdo - add ``force`` option (ansible-collections/community.general#2101).

community.network
- edgeos_config - match the space after ``set`` and ``delete`` commands (ansible-collections/community.network#199).
- nclu - execute ``net commit description <description>`` only if changed ``net pending``'s diff field (ansible-collections/community.network#219).

community.postgresql
- postgresql_info - add the ``patch``, ``full``, and ``raw`` values of the ``version`` return value (ansible-collections/community.postgresql#68).
- postgresql_ping - add the ``patch``, ``full``, and ``raw`` values of the ``server_version`` return value (ansible-collections/community.postgresql#70).

community.zabbix
- zabbix_agent - added support for installations on arm64 systems (ansible-collections/community.zabbix#320).
- zabbix_proxy - now supports configuring StatsAllowedIP (ansible-collections/community.zabbix#337).
- zabbix_server - added support for installtions on arm64 systems (ansible-collections/community.zabbix#320).
- zabbix_web - added support for installtions on arm64 systems (ansible-collections/community.zabbix#320).

dellemc.openmanage
- ome_template - Allows to deploy a template on device groups.

hetzner.hcloud
- Add firewalls to hcloud_server module

ovirt.ovirt
- cluster_upgrade - Add correlation-id header (oVirt/ovirt-ansible-collection#222).
- engine_setup - Add skip renew pki confirm (oVirt/ovirt-ansible-collection#228).
- examples - Add recipe for removing DM device (oVirt/ovirt-ansible-collection#233).
- hosted_engine_setup - Filter devices with unsupported bond mode (oVirt/ovirt-ansible-collection#226).
- infra - Add reboot host parameters (oVirt/ovirt-ansible-collection#231).
- ovirt_disk - Add SATA support (oVirt/ovirt-ansible-collection#225).
- ovirt_user - Add ssh_public_key (oVirt/ovirt-ansible-collection#232)

purestorage.flasharray
- purefa_maintenance - New module to set maintenance windows
- purefa_pg - Add support to rename protection groups
- purefa_syslog - Add support for naming SYSLOG servers for Purity//FA 6.1 or higher

purestorage.flashblade
- purefb_certs - Add update functionality for array cert
- purefb_fs - Add multiprotocol ACL support
- purefb_info - Add information regarding filesystem multiprotocol (where available)
- purefb_info - Add new parameter to provide details on admin users
- purefb_info - Add replication performace statistics
- purefb_s3user - Add ability to remove an S3 users existing access key
@Andersson007
Copy link
Contributor

@dacodas hi, thanks for your contribution! We could add your GH login to .github/BOTMETA.yml in a corresponding team as a maintainer.
You'll be notified about Issues/PRs related to this stuff and your shipit will be counted by bot for automerge (needs two for bugfixes and minor changes).
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminvakil aminvakil aminvakil approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
community_review database feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dacodas @ansibullbot @felixfontein @aminvakil @Andersson007