nmcli - fixing idempotency bug for 'dummy' connections and 'mtu' option #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ajpantuso Please create a new PR using a branch in your fork. |
|
Fixed this on my end. Should have checked my remotes in my new dev environment. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Dummy connections do not default
802-3-ethernet.mtutoautoif no value is explicitly provided. This is in contrast to other connection types which requires an additional check.Fixes #3612
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nmcli.py
ADDITIONAL INFORMATION
ethernetconnection type to confirm that nullmtudoes result inautobeing set in that case and this is specific todummyconnections