[PR #2386/17c3708f backport][stable-4] Bugfix: github_repo does not apply defaults on existing repos #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* github_repo do not apply defaults on currently existing repos * Fixed sanity * Fixed doc defaults * Added changelog * Fix "or" statement and some formatting * Improve description change check * Added api_url parameter for unit tests and default values for private and description parameters * Added force_defaults parameter * Improved docs * Fixed doc anchors for force_defaults parameter * Update plugins/modules/source_control/github/github_repo.py Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 17c3708)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-4/17c3708f31631ce6a10c39ccc0ef3405feb94f04/pr-2386
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2386 as merged into main (17c3708).
SUMMARY
Fixes #2376.
Module github_repo sets parameter default values when not specified in existing repos.
ISSUE TYPE
COMPONENT NAME
github_repo
ADDITIONAL INFORMATION
Module github_repo is applying defaults when repo already exists. However, defaults must be set only when the repo is created. Otherwise, not specifying a parameter will apply default value, which is a wrong behaviour.
Also, two tests are include in order to ensure this behaviour:
test_create_new_org_repo_incomplete: new repo with default valuestest_idempotency_existing_org_private_repo: preserveprivateanddescriptionon existing repos