Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3702/4013d0c9 backport][stable-4] Support IPMI encryption key parameter in ipmi_boot #3770

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 22, 2021

This is a backport of PR #3702 as merged into main (4013d0c).

SUMMARY

Fixes #3698

This is a very naive PoC on how passing an IPMI encryption key to the ipmi_boot module could work. Similar change is needed in the ipmi_power module.

I would like feedback on if this is feasible - especially on things like portability. I am not sure it works on all Python versions and so on.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ipmi_boot

ADDITIONAL INFORMATION
no change to output

* Support IPMI encryption key parameter in ipmi_boot

* Support py2 on hex parsing, error handling

Change parsing hex string to support python2 and add error handling to it based on feedback.

* Don't explicitly set required to false

* Add version_added to key arg

* Add changelog fragment

* Add IPMI encryption key arg to ipmi_power

* Fix the formatting of changelog fragment

(cherry picked from commit 4013d0c)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) remote_management labels Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #3770 (4013d0c) into stable-4 (d53052f) will increase coverage by 0.08%.
The diff coverage is 34.89%.

❗ Current head 4013d0c differs from pull request most recent head 0d18348. Consider uploading reports for the commit 0d18348 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           stable-4    #3770      +/-   ##
============================================
+ Coverage     43.56%   43.65%   +0.08%     
============================================
  Files           926      928       +2     
  Lines         90108    90590     +482     
  Branches      16522    16607      +85     
============================================
+ Hits          39259    39544     +285     
- Misses        49103    49291     +188     
- Partials       1746     1755       +9     
Flag Coverage Δ
integration 72.02% <80.00%> (+0.05%) ⬆️
sanity 21.32% <17.94%> (-0.04%) ⬇️
stub 0.00% <0.00%> (ø)
units 66.91% <42.95%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.azure-pipelines/scripts/publish-codecov.py 0.00% <0.00%> (ø)
plugins/modules/clustering/consul/consul.py 20.37% <ø> (ø)
...dules/remote_management/redfish/redfish_command.py 13.46% <ø> (ø)
...odules/remote_management/redfish/redfish_config.py 22.58% <0.00%> (-1.56%) ⬇️
.../modules/remote_management/redfish/redfish_info.py 12.19% <0.00%> (-0.21%) ⬇️
plugins/module_utils/redfish_utils.py 7.23% <2.05%> (-0.35%) ⬇️
...lugins/modules/remote_management/ipmi/ipmi_boot.py 30.50% <14.28%> (-2.19%) ⬇️
...ugins/modules/remote_management/ipmi/ipmi_power.py 39.13% <14.28%> (-4.46%) ⬇️
plugins/modules/cloud/lxd/lxd_container.py 19.34% <20.00%> (-0.49%) ⬇️
...les/source_control/gitlab/gitlab_group_variable.py 27.43% <25.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6589a7...0d18348. Read the comment docs.

@felixfontein felixfontein merged commit 6e51690 into stable-4 Nov 22, 2021
@felixfontein felixfontein deleted the patchback/backports/stable-4/4013d0c9caf50e863a5e8076d5809f01f0e13340/pr-3702 branch November 22, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) remote_management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants