Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java_cert - invoke run_command passing list #3835

Merged
merged 2 commits into from
Dec 3, 2021
Merged

java_cert - invoke run_command passing list #3835

merged 2 commits into from
Dec 3, 2021

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 2, 2021

SUMMARY

Passing command as list instead of as string.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/system/java_cert.py

@ansibullbot
Copy link
Collaborator

cc @absynth76 @haad
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) system and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 2, 2021
@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 3, 2021
@felixfontein felixfontein merged commit 6b91c56 into ansible-collections:main Dec 3, 2021
@patchback
Copy link

patchback bot commented Dec 3, 2021 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/6b91c56c4e73fda9d10d11cecc9f938a64ccd710/pr-3835

Backported as #3842

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 3, 2021
patchback bot pushed a commit that referenced this pull request Dec 3, 2021
@russoz @patchback
java_cert - invoke run_command passing list (#3835)
31a21fa 
* java_cert - invoke run_command passing list

* added changelog fragment

(cherry picked from commit 6b91c56)
@felixfontein
Copy link
Collaborator

@russoz thanks!

@patchback patchback bot mentioned this pull request Dec 3, 2021
Merged
felixfontein pushed a commit that referenced this pull request Dec 3, 2021
@patchback @russoz
java_cert - invoke run_command passing list (#3835) (#3842)
d2214af 
* java_cert - invoke run_command passing list

* added changelog fragment

(cherry picked from commit 6b91c56)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the java-cert-run-list branch December 3, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein