hponcfg - revamped the module using ModuleHelper #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment has been minimized.
This comment has been minimized.
ansibullbot
added
ci_verified
This comment has been minimized.
This comment has been minimized.
russoz
commented
Dec 2, 2021
This comment has been minimized.
This comment has been minimized.
ansibullbot
removed
ci_verified
felixfontein
added
backport-4
check-before-release
|
Will merge in ~a week if nobody complains. |
felixfontein
removed
the
check-before-release
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #3891 🤖 @patchback |
|
@russoz thanks for this one as well! |
patchback bot
pushed a commit
that referenced
this pull request
Dec 11, 2021
* hponcfg - revamped the module using ModuleHelper * added changelog fragment * fixed imports * Update plugins/modules/remote_management/hpilo/hponcfg.py * fixed (cherry picked from commit 7cbe1bc)
felixfontein
pushed a commit
that referenced
this pull request
Dec 11, 2021
* hponcfg - revamped the module using ModuleHelper * added changelog fragment * fixed imports * Update plugins/modules/remote_management/hpilo/hponcfg.py * fixed (cherry picked from commit 7cbe1bc) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Revamped the module using ModuleHelper. By default that adds the improvement on calling
run_commandwith a list instead of a string.ISSUE TYPE
COMPONENT NAME
plugins/modules/remote_management/hpilo/hponcfg.py