Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception in the mail callback plugin #4026

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix exception in the mail callback plugin #4026

merged 1 commit into from
Jan 20, 2022

Conversation

L3n41c
Copy link
Contributor

@L3n41c L3n41c commented Jan 11, 2022 •
edited
Loading

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.mail callback plugin

ADDITIONAL INFORMATION

@L3n41c L3n41c changed the title Fix exception in the mail callback plugin Fix exception in the mail callback plugin Jan 11, 2022
@ansibullbot
Copy link
Collaborator

cc @dagwieers
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug callback callback plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 11, 2022
@felixfontein felixfontein added backport-3 check-before-release PR will be looked at again shortly before release and merged if possible. labels Jan 12, 2022
felixfontein
felixfontein reviewed Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Could you please add a changelog fragment?

I'm not sure whethe this change is correct on Python 2 though, depending on which encoding is used.

plugins/callback/mail.py Outdated Show resolved Hide resolved
felixfontein
felixfontein reviewed Jan 17, 2022
View reviewed changes
changelogs/fragments/4026-fix-mail-callback.yml Outdated Show resolved Hide resolved
changelogs/fragments/4026-fix-mail-callback.yml Outdated Show resolved Hide resolved
plugins/callback/mail.py Outdated Show resolved Hide resolved
plugins/callback/mail.py Outdated Show resolved Hide resolved
plugins/callback/mail.py Outdated Show resolved Hide resolved
@L3n41c L3n41c mentioned this pull request Jan 19, 2022
Merged
@L3n41c L3n41c mentioned this pull request Jan 19, 2022
Merged
@L3n41c
Copy link
Contributor Author

L3n41c commented Jan 19, 2022

@felixfontein: I’ve now extracted the two fixes not directly linked to the crash in their dedicated PR.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 19, 2022
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 20, 2022
@felixfontein felixfontein merged commit c7500c2 into ansible-collections:main Jan 20, 2022
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/c7500c217fa874355e3eb99a1c9406d084a76f14/pr-4026

Backported as #4063

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 20, 2022
patchback bot pushed a commit that referenced this pull request Jan 20, 2022
@L3n41c @patchback
Fix exception in the mail callback plugin (#4026)
11eb93e 
(cherry picked from commit c7500c2)
@patchback patchback bot mentioned this pull request Jan 20, 2022
Merged
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to stable-4: cherry-pick succeeded

Backport PR branch: patchback/backports/stable-4/c7500c217fa874355e3eb99a1c9406d084a76f14/pr-4026

PR branch created, proceeding with making a PR.

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@L3n41c thanks for fixing this!

@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/c7500c217fa874355e3eb99a1c9406d084a76f14/pr-4026

Backported as #4064

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 20, 2022
@L3n41c @patchback
Fix exception in the mail callback plugin (#4026)
e125829 
(cherry picked from commit c7500c2)
@patchback patchback bot mentioned this pull request Jan 20, 2022
Merged
@L3n41c L3n41c deleted the fix_exception_mail branch January 20, 2022 08:03
felixfontein pushed a commit that referenced this pull request Jan 20, 2022
@patchback @L3n41c
Fix exception in the mail callback plugin (#4026) (#4064)
b97ce10 
(cherry picked from commit c7500c2)

Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jan 20, 2022
@patchback @L3n41c
Fix exception in the mail callback plugin (#4026) (#4063)
08eac05 
(cherry picked from commit c7500c2)

Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com>
@patchback patchback bot mentioned this pull request Jan 21, 2022
Merged
@patchback patchback bot mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug callback callback plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mail callback plugin is throwing an Exception
3 participants
@L3n41c @ansibullbot @felixfontein