-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry: enrich services for jenkins, hetzner or jira #4105
Merged
felixfontein
merged 4 commits into
ansible-collections:main
from
v1v:feature/support-otel-more-service
Feb 12, 2022
Merged
opentelemetry: enrich services for jenkins, hetzner or jira #4105
felixfontein
merged 4 commits into
ansible-collections:main
from
v1v:feature/support-otel-more-service
Feb 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
Work in progress
callback
callback plugin
feature
This issue/PR relates to a feature request
plugins
plugin (any type)
small_patch
Hopefully easy to review
labels
Jan 28, 2022
felixfontein
added
backport-4
check-before-release
PR will be looked at again shortly before release and merged if possible.
labels
Jan 29, 2022
ansibullbot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jan 29, 2022
v1v
changed the title
opentelemetry: enrich services for jenkins, hetzner, jira, zypper, chocolatey
opentelemetry: enrich services for jenkins, hetzner or jira
Feb 9, 2022
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
merge_commit
This PR contains at least one merge commit. Please resolve!
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
and removed
WIP
Work in progress
small_patch
Hopefully easy to review
stale_ci
CI is older than 7 days, rerun before merging
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
Feb 9, 2022
changelogs/fragments/4105-opentelemetry_plugin-enrich_jira_hetzner_jenkins_services.yaml
Outdated
Show resolved
Hide resolved
Those arguments can be later on in the future added, maybe with some opt-in feature, so let's only focus in the ones which are fully http based for now
…zner_jenkins_services.yaml Co-authored-by: Felix Fontein <felix@fontein.de>
v1v
force-pushed
the
feature/support-otel-more-service
branch
from
February 11, 2022 18:24
c4fbdd5
to
c561d2e
Compare
ansibullbot
added
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
and removed
merge_commit
This PR contains at least one merge commit. Please resolve!
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
labels
Feb 11, 2022
ansibullbot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
and removed
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
Feb 11, 2022
felixfontein
approved these changes
Feb 12, 2022
felixfontein
removed
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
Feb 12, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4190 🤖 @patchback |
@v1v thanks for contributing this! |
patchback bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
* opentelemetry: enrich services for jenkins, hetzner, jira, zypper, chocolatey * remove source and name for the time being Those arguments can be later on in the future added, maybe with some opt-in feature, so let's only focus in the ones which are fully http based for now * changelog fragment * Update changelogs/fragments/4105-opentelemetry_plugin-enrich_jira_hetzner_jenkins_services.yaml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit aa554c2)
felixfontein
pushed a commit
that referenced
this pull request
Feb 12, 2022
…4190) * opentelemetry: enrich services for jenkins, hetzner, jira, zypper, chocolatey * remove source and name for the time being Those arguments can be later on in the future added, maybe with some opt-in feature, so let's only focus in the ones which are fully http based for now * changelog fragment * Update changelogs/fragments/4105-opentelemetry_plugin-enrich_jira_hetzner_jenkins_services.yaml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit aa554c2) Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Enrich the span metadata for those ansible tasks that interact with:
ISSUE TYPE
COMPONENT NAME
callback/opentelemetry.py
ADDITIONAL INFORMATION