Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail callback: fully use Ansible's option handling; deprecate not specifying sender #4140

Merged
merged 2 commits into from
Feb 1, 2022
Merged

mail callback: fully use Ansible's option handling; deprecate not specifying sender #4140

merged 2 commits into from
Feb 1, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

See the discussions in #4061.

While right now it is not possible to specify lists in ansible.cfg except as comma-separated lists, this allows us to get rid of the split(',') in favor of something that's more future proof.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mail callback

@felixfontein felixfontein mentioned this pull request Feb 1, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @dagwieers
click here for bot help

@ansibullbot ansibullbot added callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type) labels Feb 1, 2022
@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Feb 1, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (third-party-check pipeline).

Andersson007
Andersson007 reviewed Feb 1, 2022
View reviewed changes
plugins/callback/mail.py Show resolved Hide resolved
plugins/callback/mail.py Outdated Show resolved Hide resolved
@felixfontein @Andersson007
Update plugins/callback/mail.py
21071d2 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 1, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (third-party-check pipeline).

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 1, 2022
@felixfontein felixfontein merged commit e09254d into ansible-collections:main Feb 1, 2022
@patchback
Copy link

patchback bot commented Feb 1, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/e09254df91b7c467902701fea33c51717d9adf38/pr-4140

Backported as #4141

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the mail-typing branch February 1, 2022 09:12
patchback bot pushed a commit that referenced this pull request Feb 1, 2022
@felixfontein @patchback
mail callback: fully use Ansible's option handling; deprecate not spe…
bf70326 
…cifying sender (#4140)

* Fully use Ansible's option handling. Deprecate not specifying sender.

* Update plugins/callback/mail.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit e09254d)
@patchback patchback bot mentioned this pull request Feb 1, 2022
Merged
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing this!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Feb 1, 2022
felixfontein added a commit that referenced this pull request Feb 1, 2022
@patchback @felixfontein
mail callback: fully use Ansible's option handling; deprecate not spe…
b48a5c2 
…cifying sender (#4140) (#4141)

* Fully use Ansible's option handling. Deprecate not specifying sender.

* Update plugins/callback/mail.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit e09254d)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
callback callback plugin feature This issue/PR relates to a feature request plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @Andersson007