linode: support cache in Linode dynamic inventory #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Charliekenney23 @InTheCloudDan @LBGarber @decentral1se @displague @rmcintosh |
ansibullbot
added
cloud
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
wbh1
force-pushed
the
feat/linode_inventory_cache
branch
from
a7c3c3a
to
9f855d3
Compare
ansibullbot
removed
ci_verified
felixfontein
added
backport-4
check-before-release
wbh1
force-pushed
the
feat/linode_inventory_cache
branch
from
9f855d3
to
7c7a0b9
Compare
ansibullbot
added
needs_ci
wbh1
force-pushed
the
feat/linode_inventory_cache
branch
from
7c7a0b9
to
9e58b29
Compare
felixfontein
approved these changes
Feb 16, 2022
|
Looks good to me! If nobody complains, I'll merge it this weekend. |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4234 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Feb 18, 2022
(cherry picked from commit f6e0693)
|
@wbh1 thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support for caching results from the Linode dynamic inventory plugin.
Because the Linode API module uses non-serializable custom classes, I store the raw JSON response from the API in the cache and recreate the
Instanceobjects when reading from cache.ISSUE TYPE
COMPONENT NAME
linode
ADDITIONAL INFORMATION
I've confirmed that the inventory works as expected both with cache disabled and with it enabled.