[PR #4192/da49c096 backport][stable-4] passwordstore: Prevent using path as password #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Given a password stored in _path/to/secret_, requesting the password _path/to_ will literally return `path/to`. This can lead to using weak passwords by accident/mess up logic in code, based on the state of the password store. This is worked around by applying the same logic `pass` uses: If a password was returned, check if there is a .gpg file it could have come from. If not, treat it as missing. Fixes #4185 (cherry picked from commit da49c09)
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-4/da49c0968d6056e7591a324ffab210ce85f9dde4/pr-4192
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4192 as merged into main (da49c09).
SUMMARY
Given a password stored in path/to/secret, requesting the password
path/to will literally return
path/to. This can lead to usingweak passwords by accident/mess up logic in code, based on the
state of the password store.
This is worked around by applying the same logic
passuses:If a password was returned, check if there is a .gpg file it could
have come from. If not, treat it as missing.
Fixes #4185
ISSUE TYPE
COMPONENT NAME
passwordstore
plugins/lookup/passwordstore
ADDITIONAL INFORMATION
See: