Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when checking if Proxmox VM exists. #4287

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Fix error when checking if Proxmox VM exists. #4287

merged 3 commits into from
Mar 4, 2022

Conversation

reitermarkus
Copy link
Contributor

SUMMARY

Fixes #4278.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

Add ignore_missing parameter since we only use this for checking if a VM already exists.

@reitermarkus reitermarkus mentioned this pull request Feb 26, 2022
Closed
1 task
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @helldorado @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud has_issue module module plugins plugin (any type) small_patch Hopefully easy to review labels Feb 26, 2022
felixfontein
felixfontein reviewed Feb 27, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment?

@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Feb 27, 2022
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Feb 28, 2022
@reitermarkus @felixfontein
Reword changelog entry.
3f4528f 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

If nobody complains, I'll merge this by the end of this week.

@dsg22
Copy link
Contributor

dsg22 commented Mar 1, 2022 •
edited
Loading

We hit this issue as well on a playbook that clones VMs. The fix here only deals with half of that problem, the call to get_vm() is also wrong (it's passing the invalid parameter ignore_errors which should be ignore_missing).

I created #4306 which also fixes that case.

@felixfontein felixfontein merged commit 36ddb9b into ansible-collections:main Mar 4, 2022
@patchback
Copy link

patchback bot commented Mar 4, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/36ddb9b8e557436f95124b2da3fd0dbd50af4b01/pr-4287

Backported as #4313

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 4, 2022
@reitermarkus @patchback
Fix error when checking if Proxmox VM exists. (#4287)
7371765 
* Fix error when checking if VM exists.

* Add changelog entry.

* Reword changelog entry.

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 36ddb9b)
@patchback patchback bot mentioned this pull request Mar 4, 2022
Merged
@felixfontein
Copy link
Collaborator

@reitermarkus thanks for fixing this!

felixfontein pushed a commit that referenced this pull request Mar 4, 2022
@patchback @reitermarkus
Fix error when checking if Proxmox VM exists. (#4287) (#4313)
a56879c 
* Fix error when checking if VM exists.

* Add changelog entry.

* Reword changelog entry.

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 36ddb9b)

Co-authored-by: Markus Reiter <me@reitermark.us>
@reitermarkus reitermarkus deleted the patch-1 branch March 6, 2022 05:33
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud has_issue module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxmox: Unable to create VM
4 participants
@reitermarkus @ansibullbot @felixfontein @dsg22