pacman: add support for remove_nosave #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
feature
New parameter: remove_nosave When enabled, will pass --nosave to pacman when removing packages. --nosave cannot be used with --print-format and thus it couldn't be passed via extra_args. See ansible-collections#4315 The code adds the option right before the actual removal of the pkgs. (This is based on an initial diff from MorphBonehunter)
jraby
force-pushed
the
4315-pacman-nosave
branch
from
7a021d5
to
c0dad71
Compare
jraby
force-pushed
the
4315-pacman-nosave
branch
from
e1ff991
to
fef16a5
Compare
jraby
commented
Mar 4, 2022
jraby
commented
Mar 4, 2022
felixfontein
reviewed
Mar 4, 2022
felixfontein
added
backport-4
check-before-release
ansibullbot
removed
the
needs_ci
Co-authored-by: Felix Fontein <felix@fontein.de>
jraby
commented
Mar 4, 2022
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
ci_verified
felixfontein
reviewed
Mar 5, 2022
felixfontein
approved these changes
Mar 5, 2022
felixfontein
removed
the
check-before-release
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4329 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
* pacman: add support for remove_nosave New parameter: remove_nosave When enabled, will pass --nosave to pacman when removing packages. --nosave cannot be used with --print-format and thus it couldn't be passed via extra_args. See #4315 The code adds the option right before the actual removal of the pkgs. (This is based on an initial diff from MorphBonehunter) * changelog * Update plugins/modules/packaging/os/pacman.py Co-authored-by: Felix Fontein <felix@fontein.de> * wording * ssss * remove_package: simplify {force,extra,nosave}_args Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c698ecd)
|
@jraby thanks for implementing this! |
felixfontein
pushed a commit
that referenced
this pull request
Mar 8, 2022
* pacman: add support for remove_nosave New parameter: remove_nosave When enabled, will pass --nosave to pacman when removing packages. --nosave cannot be used with --print-format and thus it couldn't be passed via extra_args. See #4315 The code adds the option right before the actual removal of the pkgs. (This is based on an initial diff from MorphBonehunter) * changelog * Update plugins/modules/packaging/os/pacman.py Co-authored-by: Felix Fontein <felix@fontein.de> * wording * ssss * remove_package: simplify {force,extra,nosave}_args Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c698ecd) Co-authored-by: Jean Raby <jean@raby.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
New parameter:
remove_nosaveWhen enabled, will pass
--nosaveto pacman when removing packages.--nosavecannot be used with--print-formatand thus it couldn't bepassed via extra_args. See #4315
The code adds the option right before the actual removal of the pkgs.
(This is based on an initial diff from @MorphBonehunter)
ISSUE TYPE
COMPONENT NAME
pacman