Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support to create L2TP and PPTP VPN connection #4746

Merged
merged 24 commits into from
Jun 6, 2022
Merged

add support to create L2TP and PPTP VPN connection #4746

merged 24 commits into from
Jun 6, 2022

Conversation

jremerich
Copy link
Contributor

SUMMARY

Add support to nmcli module to manage L2TP and PPTP VPN connections.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/net_tools/nmcli.py

ADDITIONAL INFORMATION

It manages VPN connections of service types L2TP and PPTP on the host

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels May 29, 2022
felixfontein
felixfontein reviewed May 29, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I've added some first comments. Please also add a changelog fragment.

plugins/modules/net_tools/nmcli.py Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels May 29, 2022
jremerich and others added 8 commits May 29, 2022 17:51
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
c013a9e 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
69019aa 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
b92fcf5 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
51ad440 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
b59d924 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
254de2f 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
72593ab 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
11f8262 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot

This comment was marked as outdated.

Sign in to view
@jremerich
apply changes pointed on tests and review
1b6736c 
- add changelog fragment
- change example code to use jinja2 in place of shell command
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label May 29, 2022
felixfontein
felixfontein reviewed May 30, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests for this to tests/unit/plugins/modules/net_tools/test_nmcli.py.

plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
jremerich and others added 3 commits May 30, 2022 10:30
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
ed5fa87 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich @felixfontein
Update plugins/modules/net_tools/nmcli.py
ceeb8eb 
Co-authored-by: Felix Fontein <felix@fontein.de>
@jremerich
removes linux command from examples
e4ce238
felixfontein
felixfontein reviewed May 31, 2022
View reviewed changes
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jremerich @ansibullbot @felixfontein