Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4810/57e83ac8 backport][stable-5] alternatives: Fix bug with priority default #4835

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 13, 2022

This is a backport of PR #4810 as merged into main (57e83ac).

If neigther the priority nor the subcommands where specified the module decided to update the priority with the default value anyway. This resulted in the bug #4803 and #4804 when the subcommands have not been specified.

SUMMARY

Do not set the priority if the default value if the priority is not set.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

alternatives

ADDITIONAL INFORMATION

* alternatives: Fix bug with priority default

If neigther the priority nor the subcommands where specified the module decided to update the priority with the default value anyway. This resulted in bug #4803 and #4804

* Add changelog fragment.

* Distinguish None from 0.

* Address review comments.

* Update plugins/modules/system/alternatives.py

Co-authored-by: Pilou <pierre-louis@libregerbil.fr>

* Remove unrelated issues from changelog.

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Pilou <pierre-louis@libregerbil.fr>
(cherry picked from commit 57e83ac)
@ansibullbot
Copy link
Collaborator

cc @mulby
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 13, 2022
@felixfontein felixfontein merged commit 4275bfe into stable-5 Jun 13, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/57e83ac80b727c472d0c3911d9189ae667feb110/pr-4810 branch June 13, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants