Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4871/1eee35df backport][stable-4] Disable opentelemetry installation for unit tests #4872

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 21, 2022

This is a backport of PR #4871 as merged into main (1eee35d).

SUMMARY

Regularly CI (unit tests) is breaking because Protobuf for Python that's required by opentelemetry:

01:16 ______ ERROR collecting tests/unit/plugins/callback/test_opentelemetry.py ______
01:16 tests/unit/plugins/callback/test_opentelemetry.py:12: in <module>
01:16     from ansible_collections.community.general.plugins.callback.opentelemetry import OpenTelemetrySource, TaskData, CallbackModule
01:16 <frozen importlib._bootstrap>:991: in _find_and_load
01:16     ???
01:16 <frozen importlib._bootstrap>:975: in _find_and_load_unlocked
01:16     ???
01:16 <frozen importlib._bootstrap>:671: in _load_unlocked
01:16     ???
01:16 /root/ansible/lib/ansible/utils/collection_loader/_collection_finder.py:434: in exec_module
01:16     exec(code_obj, module.__dict__)
01:16 plugins/callback/opentelemetry.py:89: in <module>
01:16 E    1. Downgrade the protobuf package to 3.20.x or lower.
01:16 E    2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).
01:16 E   
01:16 E   More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

(Python 3.8 and 3.9)

See for example https://dev.azure.com/ansible/community.general/_build/results?buildId=45905&view=results

This is usually fixed after a couple of days, but this is really annoying me, so I'm going to disable these tests by removing the dependencies from tests/unit/requirements.txt.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

unit tests

@felixfontein felixfontein merged commit b5fb390 into stable-4 Jun 21, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/1eee35dffbaf5952e4a24da750c008092dfc8ba3/pr-4871 branch June 21, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant