-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul session token #5193
Consul session token #5193
Conversation
cdf25fd
to
ef0fc1e
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some comments below.
ef0fc1e
to
80a7ec2
Compare
Thank you for your review, all suggestions have been taken into account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably a good idea to split this up into two PRs. They concern two completely unrelated things.
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
80a7ec2
to
3ee8c80
Compare
I'll keep this open for a bit in case someone else wants to comment, but if nobody comments I'll merge :) |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5222 🤖 @patchback |
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> (cherry picked from commit feabe20)
@wilfriedroset thanks a lot for contributing this! |
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> (cherry picked from commit feabe20) Co-authored-by: wilfriedroset <wilfriedroset@users.noreply.github.com>
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com> Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
SUMMARY
This change allow to use a token when creating a session.
It also fixes the fact that session_id was taken as an argument of consul_kv but not applied when creating a new key/pair.
ISSUE TYPE
COMPONENT NAME
consul_kv
consul_session
ADDITIONAL INFORMATION
Before
After