django_manage: deprecate venv creation when missing #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
The remaining CI failures are unrelated. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5412 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
* deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * minor change to help future removal of feature Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit f5ca030)
felixfontein
removed
the
check-before-release
|
@russoz thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Oct 23, 2022
* deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * minor change to help future removal of feature Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit f5ca030) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
russoz
added a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
…ons#5405) * deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * minor change to help future removal of feature Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…ons#5405) * deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * minor change to help future removal of feature Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…ons#5405) * deprecate venv creation when missing * add changelog fragment * fix sanity checks * Update changelogs/fragments/5404-django-manage-venv-deprecation.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/web_infrastructure/django_manage.py Co-authored-by: Felix Fontein <felix@fontein.de> * minor change to help future removal of feature Co-authored-by: Felix Fontein <felix@fontein.de>
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As pointed out in #5374 (comment)
creating the virtualenv from within
django_manageis not only a bad design decision but it simply does not work as it is.ISSUE TYPE
COMPONENT NAME
django_manage