-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to force dig lookup to return empty list #5439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add a changelog fragment as well?
ansibullbot
added
bug
This issue/PR relates to a bug
lookup
lookup plugin
plugins
plugin (any type)
labels
Oct 29, 2022
done. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
…f empty strings. fixes #5428
felixfontein
approved these changes
Oct 29, 2022
felixfontein
added
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
Oct 29, 2022
@jpmens thanks for improving the plugin! |
felixfontein
removed
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
Nov 1, 2022
rekup
pushed a commit
to rekup/community.general
that referenced
this pull request
Nov 3, 2022
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 5, 2022
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
1 task
1 task
1 task
1 task
ghost
mentioned this pull request
Nov 7, 2022
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Nov 7, 2022
Closed
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fix causes dig lookup to return an empty list instead of a list of empty strings, behaviour which was probably erroneously introduced years ago but which seems a bug.
Fixes #5428
ISSUE TYPE
COMPONENT NAME
dig
ADDITIONAL INFORMATION