-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookups: use Ansible's config manager whenever possible #5440
Conversation
…t's not interfere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from the one formatting nit, it looks good to me.
@@ -21,22 +21,26 @@ | |||
- In addition to (default) A record, it is also possible to specify a different record type that should be queried. | |||
This can be done by either passing-in additional parameter of format qtype=TYPE to the dig lookup, or by appending /TYPE to the FQDN being queried. | |||
- If multiple values are associated with the requested record, the results will be returned as a comma-separated list. | |||
In such cases you may want to pass option wantlist=True to the plugin, which will result in the record values being returned as a list | |||
over which you can iterate later on. | |||
In such cases you may want to pass option I(wantlist=true) to the lookup call, or alternatively use C(query) instead of C(lookup), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this italic I()
and not constant width C()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because options are usually formatted this way (see https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#linking-and-other-format-macros-within-module-documentation). I'm not entirely sure of this one since wantlist
is not an option of the lookup, but of lookup()
itself.
This comment was marked as outdated.
This comment was marked as outdated.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
SUMMARY
It has been there for years, so let's use it :)
ISSUE TYPE
COMPONENT NAME
lookup plugins