Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tags delimiter #5602

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Updated tags delimiter #5602

merged 3 commits into from
Dec 4, 2022

Conversation

domelek
Copy link
Contributor

@domelek domelek commented Nov 25, 2022

Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.

SUMMARY

Replaced commas to semicolons in the tags string, then delimited by semicolons.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@domelek
Updated tags delimiter
f717926 
Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @ilijamt @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 25, 2022
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 25, 2022
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 25, 2022
@Thulium-Drake
Copy link
Contributor

Simple, effective :-)

Thanks for this!

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Nov 26, 2022
felixfontein
felixfontein reviewed Nov 26, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Dec 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein merged commit 632fc07 into ansible-collections:main Dec 4, 2022
@patchback
Copy link

patchback bot commented Dec 4, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/632fc07e65778cf236a8da35bf4204bddcd052b0/pr-5602

Backported as #5651

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 4, 2022
patchback bot pushed a commit that referenced this pull request Dec 4, 2022
@domelek @patchback
Updated tags delimiter (#5602)
67a3b28 
* Updated tags delimiter

Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.

* Added missing space

* Add changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 632fc07)
@patchback patchback bot mentioned this pull request Dec 4, 2022
Merged
@patchback
Copy link

patchback bot commented Dec 4, 2022 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/632fc07e65778cf236a8da35bf4204bddcd052b0/pr-5602

Backported as #5652

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@domelek thanks for fixing this!
@Thulium-Drake thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Dec 4, 2022
@domelek @patchback
Updated tags delimiter (#5602)
92515eb 
* Updated tags delimiter

Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.

* Added missing space

* Add changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 632fc07)
@patchback patchback bot mentioned this pull request Dec 4, 2022
Merged
felixfontein pushed a commit that referenced this pull request Dec 4, 2022
@patchback @domelek
[PR #5602/632fc07e backport][stable-5] Updated tags delimiter (#5651)
ac5bbe6 
Updated tags delimiter (#5602)

* Updated tags delimiter

Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.

* Added missing space

* Add changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 632fc07)

Co-authored-by: domelek <40233039+domelek@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Dec 4, 2022
@patchback @domelek
[PR #5602/632fc07e backport][stable-6] Updated tags delimiter (#5652)
2b0e335 
Updated tags delimiter (#5602)

* Updated tags delimiter

Starting from Proxmox 7.3 tags are delimited by semicolon. For backward compatibility it needs to be splitted by both commas and semicolons.

* Added missing space

* Add changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 632fc07)

Co-authored-by: domelek <40233039+domelek@users.noreply.github.com>
@GuillaumeV-cemea GuillaumeV-cemea mentioned this pull request Dec 20, 2022
Merged
@patchback patchback bot mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domelek @ansibullbot @Thulium-Drake @felixfontein