Fix for vmadm get_vm_uuid out of range #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: IndexError: Replacement index 1 out of range for positional args tuple
fatal: [192.168.1.111]: FAILED! => {"changed": false, "module_stderr": "Shared connection to 192.168.1.111 closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 107, in <module>\r\n _ansiballz_main()\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 99, in _ansiballz_main\r\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 47, in invoke_module\r\n runpy.run_module(mod_name='ansible_collections.community.general.plugins.modules.vmadm', init_globals=dict(_module_fqn='ansible_collections.community.general.plugins.modules.vmadm', _modlib_path=modlib_path),\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 224, in run_module\r\n return _run_module_code(code, init_globals, run_name, mod_spec)\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 96, in _run_module_code\r\n _run_code(code, mod_globals, init_globals,\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 86, in _run_code\r\n exec(code, run_globals)\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 785, in <module>\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 730, in main\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 441, in get_vm_uuid\r\nIndexError: Replacement index 1 out of range for positional args tuple\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}
```
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Could you please add a changelog fragment? Thanks!
felixfontein
added
check-before-release
```bash
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: IndexError: Replacement index 1 out of range for positional args tuple
fatal: [192.168.1.111]: FAILED! => {"changed": false, "module_stderr": "Shared connection to 192.168.1.111 closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 107, in <module>\r\n _ansiballz_main()\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 99, in _ansiballz_main\r\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 47, in invoke_module\r\n runpy.run_module(mod_name='ansible_collections.community.general.plugins.modules.vmadm', init_globals=dict(_module_fqn='ansible_collections.community.general.plugins.modules.vmadm', _modlib_path=modlib_path),\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 224, in run_module\r\n return _run_module_code(code, init_globals, run_name, mod_spec)\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 96, in _run_module_code\r\n _run_code(code, mod_globals, init_globals,\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 86, in _run_code\r\n exec(code, run_globals)\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 785, in <module>\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 730, in main\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 441, in get_vm_uuid\r\nIndexError: Replacement index 1 out of range for positional args tuple\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}
```
done! |
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Nov 30, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5634 🤖 @patchback |
|
@cneira thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Fix for vmadm get_vm_uuid out of range * Fix for vmadm get_vm_uuid out of range * Update changelogs/fragments/5628-fix-vmadm-off-by-one.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b8545d1)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5635 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Fix for vmadm get_vm_uuid out of range * Fix for vmadm get_vm_uuid out of range * Update changelogs/fragments/5628-fix-vmadm-off-by-one.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b8545d1)
felixfontein
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Fix for vmadm get_vm_uuid out of range * Fix for vmadm get_vm_uuid out of range * Update changelogs/fragments/5628-fix-vmadm-off-by-one.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b8545d1) Co-authored-by: Carlos Neira <cneirabustos@gmail.com>
felixfontein
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Fix for vmadm get_vm_uuid out of range * Fix for vmadm get_vm_uuid out of range * Update changelogs/fragments/5628-fix-vmadm-off-by-one.yml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b8545d1) Co-authored-by: Carlos Neira <cneirabustos@gmail.com>
felixfontein
removed
the
check-before-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Method get_vm_uuid from vmadm off-by-one error.
ISSUE TYPE
COMPONENT NAME
vmadm
ADDITIONAL INFORMATION
When running a playbook using the vmadm module results in:
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: IndexError: Replacement index 1 out of range for positional args tuple fatal: [192.168.1.111]: FAILED! => {"changed": false, "module_stderr": "Shared connection to 192.168.1.111 closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 107, in <module>\r\n _ansiballz_main()\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 99, in _ansiballz_main\r\n invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n File \"/root/.ansible/tmp/ansible-tmp-1669747224.152739-62818-126536782663630/AnsiballZ_vmadm.py\", line 47, in invoke_module\r\n runpy.run_module(mod_name='ansible_collections.community.general.plugins.modules.vmadm', init_globals=dict(_module_fqn='ansible_collections.community.general.plugins.modules.vmadm', _modlib_path=modlib_path),\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 224, in run_module\r\n return _run_module_code(code, init_globals, run_name, mod_spec)\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 96, in _run_module_code\r\n _run_code(code, mod_globals, init_globals,\r\n File \"/opt/tools/lib/python3.10/runpy.py\", line 86, in _run_code\r\n exec(code, run_globals)\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 785, in <module>\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 730, in main\r\n File \"/tmp/ansible_community.general.vmadm_payload_jpca_c47/ansible_community.general.vmadm_payload.zip/ansible_collections/community/general/plugins/modules/vmadm.py\", line 441, in get_vm_uuid\r\nIndexError: Replacement index 1 out of range for positional args tuple\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}