stop passing loader/dataloader since it has been deprecated by ansible

[schurzi]

SUMMARY

remove deprecated passing of loader to listify_lookup_plugin_terms

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• cartesian
• flattened

ADDITIONAL INFORMATION

Passing the load was deprecated in Ansible (ansible/ansible#78244). This PR updates the code to remove the currently displayed deprecation warning.

Example playbook:

- hosts: localhost
  gather_facts: False
  tasks:
    - name: test
      debug:
        msg: "{{ item }}"
      with_community.general.flattened:
        - a
        - b
        - c

which produces the output:

# ansible-playbook /test.yml

PLAY [localhost] **********************************************************************************************************************************************************************************************************************************

TASK [test] ***************************************************************************************************************************************************************************************************************************************
[DEPRECATION WARNING]: "listify_lookup_plugin_terms" does not use "dataloader" anymore, the ability to pass it in will be removed in future versions. This feature will be removed in version 2.18. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.
ok: [localhost] => (item=a) => {
    "msg": "a"
}
ok: [localhost] => (item=b) => {
    "msg": "b"
}
ok: [localhost] => (item=c) => {
    "msg": "c"
}

PLAY RECAP ****************************************************************************************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

[schurzi]

I'm not entirely sure how to continue here. This PR will mute the warning, but the code will break hard once Ansible 2.18 is released, because the arguments will not match anymore.

I can think of several possible solutions:

• use try/catch to call the function with new arguments and as long as this generates an error, pass the old arguments
• check the used Ansible version and determine how to call the function
• use the python inspect module to see which arguments are needed

Can you advise how to continue?

[schurzi]

I think I found my answer in #4548 :)

[felixfontein]

Thanks a lot for your contribution! I've added some comments for the changelog fragments and comments, besides that it looks good to me.

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[patchback]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/b64929118ebf276169bd26c81e650579b3c3d207/pr-6074

Backported as #6091

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@schurzi thanks a lot for your contribution!

[patchback]

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b64929118ebf276169bd26c81e650579b3c3d207/pr-6074

Backported as #6092

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.