Fix influxdb_user grants in check mode #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petr-tichy this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
WIP
There was a problem hiding this comment.
Thanks for your contribution! Could you please rebase to remove the merge commit, and add a changelog fragment? Thanks.
felixfontein
added
check-before-release
When running in check mode, `influxdb_user` will return error when the user doesn't exist yet, instead of reporting `changed` state.
ansibullbot
added
database
plugins
felixfontein
reviewed
Mar 1, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
|
Looks formally OK to me. Will merge in three weeks if nobody objects. (I have zero influxdb knowledge.) |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #6213 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Fix influxdb_user grants in check mode When running in check mode, `influxdb_user` will return error when the user doesn't exist yet, instead of reporting `changed` state. * Update changelogs/fragments/6111-influxdb_user-check-mode.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 3fb1ff0)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6214 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
* Fix influxdb_user grants in check mode When running in check mode, `influxdb_user` will return error when the user doesn't exist yet, instead of reporting `changed` state. * Update changelogs/fragments/6111-influxdb_user-check-mode.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 3fb1ff0)
|
@petr-tichy thanks for your contribution! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
pushed a commit
that referenced
this pull request
Mar 22, 2023
…eck mode (#6213) Fix influxdb_user grants in check mode (#6111) * Fix influxdb_user grants in check mode When running in check mode, `influxdb_user` will return error when the user doesn't exist yet, instead of reporting `changed` state. * Update changelogs/fragments/6111-influxdb_user-check-mode.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 3fb1ff0) Co-authored-by: Petr Tichý <petr@pex.com>
felixfontein
pushed a commit
that referenced
this pull request
Mar 22, 2023
…eck mode (#6214) Fix influxdb_user grants in check mode (#6111) * Fix influxdb_user grants in check mode When running in check mode, `influxdb_user` will return error when the user doesn't exist yet, instead of reporting `changed` state. * Update changelogs/fragments/6111-influxdb_user-check-mode.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 3fb1ff0) Co-authored-by: Petr Tichý <petr@pex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When running in check mode,
influxdb_userwill return error when the user doesn't exist yet, instead of reportingchangedstate.ISSUE TYPE
COMPONENT NAME
influxdb_user