Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_query: add query_all_results ret value #886

Merged
merged 8 commits into from
Oct 20, 2020
Merged

postgresql_query: add query_all_results ret value #886

merged 8 commits into from
Oct 20, 2020

Conversation

Andersson007
Copy link
Contributor

SUMMARY

Fixes #838

Adds query_list and query_all_results ret values

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_query

@ansibullbot
Copy link
Collaborator

cc @Dorn- @amenonsen @andytom @archf @jbscalia @kostiantyn-nemchenko @matburt @nerzhul @sebasmannem @tcraxs @wrouesnel
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress affects_2.10 database feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) postgresql tests tests labels Sep 14, 2020
@Andersson007 Andersson007 changed the title [WIP] postgresql_query: add query_all_results ret value postgresql_query: add query_all_results ret value Sep 14, 2020
@Andersson007 Andersson007 mentioned this pull request Sep 14, 2020
Closed
@ansibullbot ansibullbot added community_review has_issue and removed WIP Work in progress labels Sep 14, 2020
@Andersson007
Copy link
Contributor Author

cc @Dorn- @amenonsen @andytom @archf @jbscalia @kostiantyn-nemchenko @matburt @nerzhul @sebasmannem @tcraxs @wrouesnel @ilicmilan

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 8, 2020
@Andersson007 Andersson007 reopened this Oct 16, 2020
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Oct 16, 2020
@Andersson007
Copy link
Contributor Author

ready_for_review

tcraxs
tcraxs reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few hints on the documentation 😉

plugins/modules/database/postgresql/postgresql_query.py Outdated Show resolved Hide resolved
plugins/modules/database/postgresql/postgresql_query.py Outdated Show resolved Hide resolved
plugins/modules/database/postgresql/postgresql_query.py Outdated Show resolved Hide resolved
Andersson007 and others added 3 commits October 19, 2020 08:23
@Andersson007
Copy link
Contributor Author

ready_for_review

tcraxs
tcraxs approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@tcraxs tcraxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007 Andersson007 merged commit 8267fd3 into ansible-collections:main Oct 20, 2020
patchback bot pushed a commit that referenced this pull request Oct 20, 2020
@Andersson007
postgresql_query: add query_all_results ret value (#886)
c98f35f 
* postgresql_query: add query_all_results ret value

* add changelog fragment

* fix CI

* fix doc

* Update plugins/modules/database/postgresql/postgresql_query.py

Co-authored-by: Tobias Birkefeld <t@craxs.de>

* Update plugins/modules/database/postgresql/postgresql_query.py

Co-authored-by: Tobias Birkefeld <t@craxs.de>

* fix doc

Co-authored-by: Tobias Birkefeld <t@craxs.de>
(cherry picked from commit 8267fd3)
@patchback patchback bot mentioned this pull request Oct 20, 2020
Merged
@Andersson007
Copy link
Contributor Author

@tcraxs thanks for reviewing!

Andersson007 added a commit that referenced this pull request Oct 20, 2020
@patchback @Andersson007
postgresql_query: add query_all_results ret value (#886) (#1131)
bb2ad10 
* postgresql_query: add query_all_results ret value

* add changelog fragment

* fix CI

* fix doc

* Update plugins/modules/database/postgresql/postgresql_query.py

Co-authored-by: Tobias Birkefeld <t@craxs.de>

* Update plugins/modules/database/postgresql/postgresql_query.py

Co-authored-by: Tobias Birkefeld <t@craxs.de>

* fix doc

Co-authored-by: Tobias Birkefeld <t@craxs.de>
(cherry picked from commit 8267fd3)

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@Andersson007 Andersson007 mentioned this pull request Dec 29, 2020
Merged
@Andersson007 Andersson007 mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcraxs tcraxs tcraxs approved these changes

Assignees
No one assigned
Labels
community_review database feature This issue/PR relates to a feature request has_issue integration tests/integration module module needs_triage plugins plugin (any type) postgresql tests tests
Projects
None yet
Milestone
No milestone
3 participants
@Andersson007 @ansibullbot @tcraxs