Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r*: normalize docs #9354

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Dec 24, 2024

SUMMARY

Normalize doc blocks.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/read_csv.py
plugins/modules/redfish_command.py
plugins/modules/redfish_config.py
plugins/modules/redfish_info.py
plugins/modules/redhat_subscription.py
plugins/modules/redis.py
plugins/modules/redis_data.py
plugins/modules/redis_data_incr.py
plugins/modules/redis_data_info.py
plugins/modules/redis_info.py
plugins/modules/rhevm.py
plugins/modules/rhsm_release.py
plugins/modules/rhsm_repository.py
plugins/modules/riak.py
plugins/modules/rocketchat.py
plugins/modules/rollbar_deployment.py
plugins/modules/rpm_ostree_pkg.py
plugins/modules/rundeck_acl_policy.py
plugins/modules/rundeck_job_executions_info.py
plugins/modules/rundeck_job_run.py
plugins/modules/rundeck_project.py
plugins/modules/runit.py

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Dec 24, 2024
plugins/modules/redis.py Outdated Show resolved Hide resolved
plugins/modules/redis.py Outdated Show resolved Hide resolved
plugins/modules/redis.py Outdated Show resolved Hide resolved
plugins/modules/rhevm.py Outdated Show resolved Hide resolved
plugins/modules/rhevm.py Outdated Show resolved Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
plugins/modules/rhevm.py Outdated Show resolved Hide resolved
plugins/modules/rhevm.py Outdated Show resolved Hide resolved
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 25, 2024
@felixfontein felixfontein merged commit 9751461 into ansible-collections:main Dec 25, 2024
129 checks passed
Copy link

patchback bot commented Dec 25, 2024

Backport to stable-9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 9751461 on top of patchback/backports/stable-9/97514612956083d585c1141ec3dbb57483519162/pr-9354

Backporting merged PR #9354 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-9/97514612956083d585c1141ec3dbb57483519162/pr-9354 upstream/stable-9
  4. Now, cherry-pick PR r*: normalize docs #9354 contents into that branch:
    $ git cherry-pick -x 97514612956083d585c1141ec3dbb57483519162
    If it'll yell at you with something like fatal: Commit 97514612956083d585c1141ec3dbb57483519162 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 97514612956083d585c1141ec3dbb57483519162
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR r*: normalize docs #9354 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-9/97514612956083d585c1141ec3dbb57483519162/pr-9354
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Dec 25, 2024

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/97514612956083d585c1141ec3dbb57483519162/pr-9354

Backported as #9377

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 25, 2024
* r*: normalize docs

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9751461)
@felixfontein
Copy link
Collaborator

@russoz thanks!

felixfontein pushed a commit that referenced this pull request Dec 25, 2024
r*: normalize docs (#9354)

* r*: normalize docs

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 9751461)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the r-docs branch December 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch docs module module plugins plugin (any type) redhat_subscription
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants