Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: replace to_native(), to_text(), str() with str() where possible or leave it away in f-string formatting #9379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

With Python 3.6+ to_native() and to_text() are glorified str() calls assuming they are not potentially decoding byte strings to unicode strings. Remove them (in f-strings) or replace them with str() if possible.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/action/shutdown.py
plugins/cache/redis.py
plugins/callback/logentries.py
plugins/callback/slack.py
plugins/connection/chroot.py
plugins/filter/from_csv.py
plugins/filter/from_ini.py
plugins/filter/to_ini.py
plugins/inventory/cobbler.py
plugins/inventory/gitlab_runners.py
plugins/inventory/iocage.py
plugins/inventory/lxd.py
plugins/inventory/nmap.py
plugins/inventory/opennebula.py
plugins/inventory/proxmox.py
plugins/inventory/scaleway.py
plugins/inventory/virtualbox.py
plugins/lookup/cyberarkpassword.py
plugins/lookup/dig.py
plugins/lookup/dnstxt.py
plugins/lookup/etcd3.py
plugins/lookup/lmdb_kv.py
plugins/lookup/manifold.py
plugins/lookup/onepassword.py
plugins/lookup/tss.py

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 25, 2024
@ansibullbot ansibullbot added action action plugin cache cache plugin callback callback plugin cloud connection connection plugin filter filter plugin inventory inventory plugin lookup lookup plugin plugins plugin (any type) labels Dec 25, 2024
@felixfontein felixfontein requested a review from russoz December 25, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action action plugin backport-10 Automatically create a backport for the stable-10 branch cache cache plugin callback callback plugin check-before-release PR will be looked at again shortly before release and merged if possible. cloud connection connection plugin filter filter plugin inventory inventory plugin lookup lookup plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants