plugins: replace to_native(), to_text(), str() with str() where possible or leave it away in f-string formatting #9379
+84
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With Python 3.6+
to_native()
andto_text()
are glorifiedstr()
calls assuming they are not potentially decoding byte strings to unicode strings. Remove them (in f-strings) or replace them withstr()
if possible.ISSUE TYPE
COMPONENT NAME
plugins/action/shutdown.py
plugins/cache/redis.py
plugins/callback/logentries.py
plugins/callback/slack.py
plugins/connection/chroot.py
plugins/filter/from_csv.py
plugins/filter/from_ini.py
plugins/filter/to_ini.py
plugins/inventory/cobbler.py
plugins/inventory/gitlab_runners.py
plugins/inventory/iocage.py
plugins/inventory/lxd.py
plugins/inventory/nmap.py
plugins/inventory/opennebula.py
plugins/inventory/proxmox.py
plugins/inventory/scaleway.py
plugins/inventory/virtualbox.py
plugins/lookup/cyberarkpassword.py
plugins/lookup/dig.py
plugins/lookup/dnstxt.py
plugins/lookup/etcd3.py
plugins/lookup/lmdb_kv.py
plugins/lookup/manifold.py
plugins/lookup/onepassword.py
plugins/lookup/tss.py