Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #219/5e2cd880 backport][stable-2] nclu: fix 'net pending' delimiter string, and exec commit only if changed #220

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 9, 2021

This is a backport of PR #219 as merged into main (5e2cd88).

SUMMARY
  • mod nclu module
    • fixed net pending 's delimiter string
      • checked version : 3.7.3, 4.0.0, 4.2.1, 4.3.0
    • execute net commit description <description> only if changed net pending's diff field.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nclu

ADDITIONAL INFORMATION

…nged (#219)

* fix 'net pendig''s delimiter string

* test for #219

* test for #219

* add changelog fragment for #219

* Update changelogs/fragments/219-nclu-fix-pending.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/219-nclu-fix-pending.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* switched to 're' to handle both cases of quotes

Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Deric Crago <deric.crago@redhat.com>
(cherry picked from commit 5e2cd88)
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (stable-2@a5da897). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable-2     #220   +/-   ##
===========================================
  Coverage            ?   44.95%           
===========================================
  Files               ?      627           
  Lines               ?    76256           
  Branches            ?    16303           
===========================================
  Hits                ?    34281           
  Misses              ?    39705           
  Partials            ?     2270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5da897...33f14e0. Read the comment docs.

@dericcrago dericcrago merged commit 11c8daa into stable-2 Mar 10, 2021
@dericcrago dericcrago deleted the patchback/backports/stable-2/5e2cd8802cf3339a8c43ce5ce6387c0b9f5872aa/pr-219 branch March 10, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants