postgresql_pg_hba: fix false "changed" when called with "overwrite: true" #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betanummeric
requested review from
Andersson007,
hunleyd and
jchancojr
as code owners
betanummeric
changed the title
betanummeric
changed the title
|
This is ready for review. A backport should not be needed as this only affects the |
hunleyd
approved these changes
Dec 1, 2022
Andersson007
reviewed
Dec 1, 2022
There was a problem hiding this comment.
@betanummeric is it possible to cover the case with integration tests? If it's tricky, no problem
|
It should be fairly easy to add a test, I can do it tomorrow. |
…ain with the same arguments (having overwrite=true)
Andersson007
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
LGTM
@nlvw thanks for reporting the issue!
@hunleyd thanks for reviewing!
@betanummeric thanks for fixing this! I think you can merge the PR yourself as there are approvals (choose "Squash and Merge", not the other options)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgresql_pg_hba bugfix
fixes #376
pg_hba.conf, trim whitespace between the rule and comment in the same line, to ensure equality tests work.overwritewas enabled, the rule list was emptied and adding rules again counted as change.