[PR #400/939c2cd6 backport][stable-1] Fix postgresql_set module if single-value param contains comma in value

[patchback]

This is a backport of PR #400 as merged into main (939c2cd).

SUMMARY

The PR #357 fix the multi-value parameters management (issue #78), but the new check assumes as multi-value each parameter with a comma in the value, that is incorrect as there are single-value parameters with comma in value.

If a single-value parameter is treated as a multi-value, the 'param_set' function builds an ALTER SYSTEM SET command with multiple comma-separated values, that fails with the message:

ERROR:  SET log_line_prefix takes only one argument

Single-value parameters with possible comma in value are "_command" and "_prefix" that for exmple in v12 are:

• ssl_passphrase_command
• archive_command
• restore_command
• archive_cleanup_command
• recovery_end_command
• log_line_prefix

The most critical (that I add in tests) is 'log_line_prefix' because often it contains comma and a space at the end.

I simply fix the check to evaluate as single-value all parameters that ends with '_command' and '_prefix'.

If the fix is accepted, It can be back-ported also in stable branch.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

postgresql_set

[hunleyd]

i assume you wanted this backported @Andersson007 ?

[Andersson007]

i assume you wanted this backported @Andersson007 ?

@hunleyd yep, generally we backport bugfixes