Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for '/ip dhcp-relay' path #276

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

vint2k
Copy link
Contributor

@vint2k vint2k commented Apr 8, 2024

SUMMARY

Support API path /ip dhcp-relay

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify

Copy link

github-actions bot commented Apr 8, 2024

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here:
https://ansible-collections.github.io/community.routeros/pr/276

You can compare to the docs for the main branch here:
https://ansible-collections.github.io/community.routeros/branch/main

The docsite for this PR is also available for download as an artifact from this run:
https://github.com/ansible-collections/community.routeros/actions/runs/8734600297

File changes:

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/api_info_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/api_info_module.html
index 83bf7b5..8af5719 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/api_info_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/api_info_module.html
@@ -397,6 +397,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">cloud</span> <span class="pre">advanced&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-client&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-client</span> <span class="pre">option&quot;</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-relay&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server</span> <span class="pre">config&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server</span> <span class="pre">lease&quot;</span></code></p></li>
diff --git a/home/runner/work/community.routeros/community.routeros/docsbuild/base/api_modify_module.html b/home/runner/work/community.routeros/community.routeros/docsbuild/head/api_modify_module.html
index ad61d5c..d389423 100644
--- a/home/runner/work/community.routeros/community.routeros/docsbuild/base/api_modify_module.html
+++ b/home/runner/work/community.routeros/community.routeros/docsbuild/head/api_modify_module.html
@@ -417,6 +417,7 @@ see <a class="reference internal" href="#ansible-collections-community-routeros-
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">cloud</span> <span class="pre">advanced&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-client&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-client</span> <span class="pre">option&quot;</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-relay&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server</span> <span class="pre">config&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;ip</span> <span class="pre">dhcp-server</span> <span class="pre">lease&quot;</span></code></p></li>

@vint2k vint2k marked this pull request as ready for review April 10, 2024 07:45
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (8351bff) to head (8872e35).
Report is 7 commits behind head on main.

❗ Current head 8872e35 differs from pull request most recent head 784e1da. Consider uploading reports for the commit 784e1da to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #276       +/-   ##
===========================================
- Coverage   82.99%   67.44%   -15.55%     
===========================================
  Files          32        2       -30     
  Lines        4051      172     -3879     
  Branches      873       39      -834     
===========================================
- Hits         3362      116     -3246     
+ Misses        506       40      -466     
+ Partials      183       16      -167     
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add a changelog fragment? You can find some examples in changelogs/fragments/.

@vint2k
Copy link
Contributor Author

vint2k commented Apr 18, 2024

@felixfontein done

@felixfontein felixfontein merged commit c6be391 into ansible-collections:main Apr 18, 2024
46 of 47 checks passed
@felixfontein
Copy link
Collaborator

@vint2k thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants