action plugin helper: fix deprecation handling #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 66.33% 66.13% -0.21%
==========================================
Files 12 12
Lines 992 995 +3
Branches 221 223 +2
==========================================
Hits 658 658
- Misses 253 256 +3
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kristianheljas
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Same feelings as in ansible-collections/community.crypto#572 (review), but LGTM!
|
@kristianheljas thanks for this one as well! |
ghost
mentioned this pull request
1 task
Stackclash
referenced
this pull request
in Stackclash/home-cluster
May 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [community.sops](https://togithub.com/ansible-collections/community.sops) | galaxy-collection | patch | `1.6.0` -> `1.6.1` | --- ### Release Notes <details> <summary>ansible-collections/community.sops</summary> ### [`v1.6.1`](https://togithub.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v161) [Compare Source](https://togithub.com/ansible-collections/community.sops/compare/1.6.0...1.6.1) \====== ## Release Summary Maintenance release. ## Bugfixes - action plugin helper - fix handling of deprecations for ansible-core 2.14.2 ([https://github.com/ansible-collections/community.sops/pull/136](https://togithub.com/ansible-collections/community.sops/pull/136)). - various plugins - remove unnecessary imports ([https://github.com/ansible-collections/community.sops/pull/133](https://togithub.com/ansible-collections/community.sops/pull/133)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/RickCoxDev/home-cluster). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuNCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi40In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a consequence of ansible/ansible#79681 and ansible/ansible#79740, which were backported to stable-2.14 and released in ansible-core 2.14.2. Without these, there will be a crash when deprecations appear with ansible-core 2.14.2+ in action plugins using this helper.
ISSUE TYPE
COMPONENT NAME
plugins/plugin_utils/action_module.py