install role: make sure pkg_mgr fact is available for localhost installs #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 65.92% 65.92%
=======================================
Files 12 12
Lines 989 989
Branches 223 223
=======================================
Hits 652 652
Misses 256 256
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
After some tries to reproduce this, and looking up the ansible-core code, I don't think this will actually fix the probem. See #145 (comment) for details. |
|
It would be nice to know why #145 actually happens, but this seems to fix it (#145 (comment)). |
felixfontein
commented
Jun 15, 2023
doonga
referenced
this pull request
in doonga/greyrock-ops
Jun 16, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [community.sops](https://togithub.com/ansible-collections/community.sops) | galaxy-collection | patch | `1.6.1` -> `1.6.2` | --- ### Release Notes <details> <summary>ansible-collections/community.sops</summary> ### [`v1.6.2`](https://togithub.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v162) [Compare Source](https://togithub.com/ansible-collections/community.sops/compare/1.6.1...1.6.2) \====== ## Release Summary Maintenance release. ## Bugfixes - install role - make sure that the `pkg_mgr` fact is definitely available when installing on `localhost`. This can improve error messages in some cases ([https://github.com/ansible-collections/community.sops/issues/145](https://togithub.com/ansible-collections/community.sops/issues/145), [https://github.com/ansible-collections/community.sops/pull/146](https://togithub.com/ansible-collections/community.sops/pull/146)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTguMCIsInVwZGF0ZWRJblZlciI6IjM1LjExOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
ghost
mentioned this pull request
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Jun 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [community.sops](https://togithub.com/ansible-collections/community.sops) | galaxy-collection | patch | `1.6.1` -> `1.6.2` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ansible-collections/community.sops (community.sops)</summary> ### [`v1.6.2`](https://togithub.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v162) [Compare Source](https://togithub.com/ansible-collections/community.sops/compare/1.6.1...1.6.2) \====== ## Release Summary Maintenance release. ## Bugfixes - install role - make sure that the `pkg_mgr` fact is definitely available when installing on `localhost`. This can improve error messages in some cases ([https://github.com/ansible-collections/community.sops/issues/145](https://togithub.com/ansible-collections/community.sops/issues/145), [https://github.com/ansible-collections/community.sops/pull/146](https://togithub.com/ansible-collections/community.sops/pull/146)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTguMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Jul 27, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [community.sops](https://github.com/ansible-collections/community.sops) | galaxy-collection | patch | `1.6.1` -> `1.6.4` | --- ### Release Notes <details> <summary>ansible-collections/community.sops (community.sops)</summary> ### [`v1.6.4`](https://github.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v164) [Compare Source](ansible-collections/community.sops@1.6.3...1.6.4) \====== ## Release Summary Maintenance/bugfix release for the move of sops to the new `getsops GitHub organization <https://github.com/getsops>`\__. ## Bugfixes - install role - fix `sops_github_latest_detection=latest-release`, which broke due to sops moving to another GitHub organization (ansible-collections/community.sops#151). ### [`v1.6.3`](https://github.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v163) [Compare Source](ansible-collections/community.sops@1.6.2...1.6.3) \====== ## Release Summary Maintenance release with updated documentation. From this version on, community.sops is using the new `Ansible semantic markup <https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation>`\__ in its documentation. If you look at documentation with the ansible-doc CLI tool from ansible-core before 2.15, please note that it does not render the markup correctly. You should be still able to read it in most cases, but you need ansible-core 2.15 or later to see it as it is intended. Alternatively you can look at `the devel docsite <https://docs.ansible.com/ansible/devel/collections/community/sops/>`\__ for the rendered HTML version of the documentation of the latest release. ## Known Issues - Ansible markup will show up in raw form on ansible-doc text output for ansible-core before 2.15. If you have trouble deciphering the documentation markup, please upgrade to ansible-core 2.15 (or newer), or read the HTML documentation on https://docs.ansible.com/ansible/devel/collections/community/sops/. ### [`v1.6.2`](https://github.com/ansible-collections/community.sops/blob/HEAD/CHANGELOG.rst#v162) [Compare Source](ansible-collections/community.sops@1.6.1...1.6.2) \====== ## Release Summary Maintenance release. ## Bugfixes - install role - make sure that the `pkg_mgr` fact is definitely available when installing on `localhost`. This can improve error messages in some cases (ansible-collections/community.sops#145, ansible-collections/community.sops#146). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Nicolas Dufour <nrdufour@gmail.com> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/7 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145.