stable-4.x: Fix sanity tests

ansible-collections · Sep 29, 2024 · 8c08257 · 8c08257
1 parent 6648b07
commit 8c08257
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 1 deletion.
diff --git a/changelogs/fragments/2186-fix-sanity-tests.yml b/changelogs/fragments/2186-fix-sanity-tests.yml
@@ -0,0 +1,5 @@
+bugfixes:
+  - vmware_dvswitch - Fix Pylint issue (https://github.com/ansible-collections/community.vmware/pull/2186).
+  - vmware_host - Fix Pylint issue (https://github.com/ansible-collections/community.vmware/pull/2186).
+  - vmware_host_dns - Fix Pylint issue (https://github.com/ansible-collections/community.vmware/pull/2186).
+  - vmware_host_powerstate - Fix Pylint issue (https://github.com/ansible-collections/community.vmware/pull/2186).
diff --git a/plugins/modules/vmware_dvswitch.py b/plugins/modules/vmware_dvswitch.py
@@ -906,6 +906,7 @@ def update_dvswitch(self):
                 config_spec.defaultPortConfig.macManagementPolicy = policy
 
         # Check switch version
+        spec_product = None
         if self.switch_version:
             results['version'] = self.switch_version
             if self.dvs.config.productInfo.version != self.switch_version:

diff --git a/plugins/modules/vmware_host.py b/plugins/modules/vmware_host.py
@@ -655,6 +655,7 @@ def state_update_host(self):
                 if reconnect or self.state == 'add_or_reconnect' or self.state == 'reconnect':
                     self.reconnect_host(self.host_update)
                 try:
+                    task = None
                     try:
                         if parent_type == 'folder':
                             # Move ESXi host from folder to folder

diff --git a/plugins/modules/vmware_host_dns.py b/plugins/modules/vmware_host_dns.py
@@ -191,6 +191,7 @@ def ensure(self):
             initial_name = host.name
             changed = False
             changed_list = []
+            dns_servers_verbose_message = None
             host_result = {'changed': '', 'msg': '', 'host_name': host.name}
 
             host_netstack_config = host.config.network.netStackInstance

diff --git a/plugins/modules/vmware_host_powerstate.py b/plugins/modules/vmware_host_powerstate.py
@@ -130,6 +130,7 @@ def ensure(self):
         host_change_list = []
         for host in self.hosts:
             changed = False
+            task = None
             if not host.runtime.inMaintenanceMode and not force:
                 self.module.fail_json(msg="Current host system '%s' is not in maintenance mode,"
                                           " please specify 'force' as True to proceed." % host.name)

diff --git a/tests/sanity/ignore-2.18.txt b/tests/sanity/ignore-2.18.txt
@@ -1,4 +1,3 @@
-meta/runtime.yml runtime-metadata!skip
 plugins/modules/vmware_deploy_ovf.py replace-urlopen!skip
 plugins/modules/vmware_deploy_ovf.py use-argspec-type-path!skip
 scripts/inventory/vmware_inventory.py pep8!skip

diff --git a/tests/sanity/ignore-2.19.txt b/tests/sanity/ignore-2.19.txt
@@ -0,0 +1,4 @@
+plugins/modules/vmware_deploy_ovf.py replace-urlopen!skip
+plugins/modules/vmware_deploy_ovf.py use-argspec-type-path!skip
+scripts/inventory/vmware_inventory.py pep8!skip
+tests/unit/mock/loader.py pep8!skip