-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACD changelog generator #103
Conversation
Generated with:
(2.10.0a2 was created with |
d466143
to
7692d6b
Compare
I've implemented some changes in antsibull-changelog's changelog generation code to allow improving the porting guide (see ansible-community/antsibull-changelog#24). |
(Probably breaks in CI until antsibull-changelog gets another release.) |
(antsibull-changelog 0.5.0 has been released with the required changes.) |
9d4a6a1
to
921e8cb
Compare
3a4008a
to
3099913
Compare
new_dependencies = DependencyFileData( | ||
str(app_ctx.extra["acd_version"]), | ||
str(ansible_base_version), | ||
{collection: str(version) for collection, version in included_versions.items()}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a request to change this code necessarily; when I wrote the type checking for DependencyFileData.__init__()
I wondered if I should make it t.Union[str, Version]
(where Version was either packaging Version or semantic version... I don't recall off the top of my head which one it is).
If you think it's more convenient to change the DependencyFileData API (now or in the future), that would be fine with me.
This looks good to me. Merge when you're ready. |
…ng guide into tarball for now.
Current output: https://gist.github.com/felixfontein/7d5efcc70c8a25c218d9e8082f5ee92f
Doesn't yet contain ansible-base's changelog.
(I've added a 2.10.0a2 release with the latest collection versions, as otherwise there are no changelogs at all.)