Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACD changelog generator #103

Merged
merged 24 commits into from
Jul 16, 2020
Merged

Conversation

felixfontein
Copy link
Collaborator

Current output: https://gist.github.com/felixfontein/7d5efcc70c8a25c218d9e8082f5ee92f

Doesn't yet contain ansible-base's changelog.

(I've added a 2.10.0a2 release with the latest collection versions, as otherwise there are no changelogs at all.)

@felixfontein
Copy link
Collaborator Author

Generated with:

antsibull-build build-changelog 2.10.0a2 --deps-dir ../ansible-build-data/2.10 --collection-cache cache

(2.10.0a2 was created with time antsibull-build build-single 2.10.0a2 --collection-cache cache --build-file ../ansible-build-data/2.10/acd-2.10.build --deps-file ../../ansible-build-data/2.10/acd-2.10.0a2.deps --dest-dir built)

@felixfontein
Copy link
Collaborator Author

I've implemented some changes in antsibull-changelog's changelog generation code to allow improving the porting guide (see ansible-community/antsibull-changelog#24).

@felixfontein
Copy link
Collaborator Author

(Probably breaks in CI until antsibull-changelog gets another release.)

@felixfontein
Copy link
Collaborator Author

(antsibull-changelog 0.5.0 has been released with the required changes.)

@felixfontein felixfontein changed the title [WIP] ACD changelog generator ACD changelog generator Jun 28, 2020
@felixfontein felixfontein force-pushed the changelog branch 2 times, most recently from 9d4a6a1 to 921e8cb Compare July 4, 2020 15:25
@felixfontein felixfontein force-pushed the changelog branch 2 times, most recently from 3a4008a to 3099913 Compare July 11, 2020 21:24
new_dependencies = DependencyFileData(
str(app_ctx.extra["acd_version"]),
str(ansible_base_version),
{collection: str(version) for collection, version in included_versions.items()})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a request to change this code necessarily; when I wrote the type checking for DependencyFileData.__init__() I wondered if I should make it t.Union[str, Version] (where Version was either packaging Version or semantic version... I don't recall off the top of my head which one it is).

If you think it's more convenient to change the DependencyFileData API (now or in the future), that would be fine with me.

@abadger
Copy link
Contributor

abadger commented Jul 16, 2020

This looks good to me. Merge when you're ready.

@felixfontein felixfontein merged commit 9342c9b into ansible-community:main Jul 16, 2020
@felixfontein felixfontein deleted the changelog branch July 16, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Priority to implement this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants